Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(704)

Issue 544643002: Revert of Try backing SkPicture with SkRecord in Chromium. (Closed)

Created:
6 years, 3 months ago by lushnikov
Modified:
6 years, 3 months ago
CC:
chromium-reviews, Stephen White, robertphillips, Tom Hudson
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Revert of Try backing SkPicture with SkRecord in Chromium. (patchset #4 id:60001 of https://codereview.chromium.org/504823003/) Reason for revert: This patch broke icons in Developer Tools: crbug.com/410847 Original issue's description: > Try backing SkPicture with SkRecord in Chromium. > > This is our first attempt, mostly to feel this out. Performance and > correctness problems are both possible. Please revert this if a benchmark even > smells funny. > > That said, we've been working on this a while, are pretty confident it's good > stuff, and have had Skia's internal testing entirely switched over for a week. > Parts of Chromium that serialize and deserialize SkPictures are already > switched over. This CL finishes things off by switching the default > recorded-from-scratch SkPicture to use SkRecord too. > > BUG=408985, 409110 > > Committed: https://chromium.googlesource.com/chromium/src/+/f7450daaf38f4951b23fabaaaf659c6af33a705c > > Committed: https://chromium.googlesource.com/chromium/src/+/5f2a6ab31313eb2fc6e456f65c3863a77d2d0c30 > > CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg;tryserver.chromium.linux:linux_browser_asan > > Committed: https://chromium.googlesource.com/chromium/src/+/130033d6c732af90ed117f05517e4efffd23ae58 TBR=reed@google.com,mtklein@google.com,senorblanco@chromium.org,eroman@chromium.org,fmalita@chromium.org,mtklein@chromium.org NOTREECHECKS=true NOTRY=true BUG=408985, 409110 Committed: https://crrev.com/c6df10449518e58f647ea40f5907041bb54639f8 Cr-Commit-Position: refs/heads/master@{#293296}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -10 lines) Patch
M skia/config/SkUserConfig.h View 2 chunks +4 lines, -7 lines 0 comments Download
M skia/skia_test_expectations.txt View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
lushnikov
Created Revert of Try backing SkPicture with SkRecord in Chromium.
6 years, 3 months ago (2014-09-04 14:27:38 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/lushnikov@chromium.org/544643002/1
6 years, 3 months ago (2014-09-04 14:29:13 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1) as bf3c771600a2f062cf75477d25f1325a72cc7624
6 years, 3 months ago (2014-09-04 14:31:39 UTC) #3
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:31:22 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c6df10449518e58f647ea40f5907041bb54639f8
Cr-Commit-Position: refs/heads/master@{#293296}

Powered by Google App Engine
This is Rietveld 408576698