public/web/WebFrame.h - Issue 544443002: Detach all subframes before swapping a frame.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: public/web/WebFrame.h

Issue 544443002: Detach all subframes before swapping a frame. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Remove ASSERT in detachChildren, since FrameLoader::commitProvisionalLoad can hit it with ref count… Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: public/web/WebFrame.h

diff --git a/public/web/WebFrame.h b/public/web/WebFrame.h

index 46d62129998e23acd9fde95d95af9b3ff4ee87d3..b8f9f97319e909c8483e7b0d7e3a30fd2ba6b761 100644

--- a/public/web/WebFrame.h

+++ b/public/web/WebFrame.h

@@ -115,7 +115,7 @@ public:

virtual bool isWebRemoteFrame() const = 0;

virtual WebRemoteFrame* toWebRemoteFrame() = 0;

- BLINK_EXPORT void swap(WebFrame*);

+ BLINK_EXPORT bool swap(WebFrame*);

// This method closes and deletes the WebFrame.

virtual void close() = 0;

« Source/web/WebFrame.cpp ('K') | « Source/web/tests/data/subframe-b.html ('k') | no next file » | no next file with comments »