Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(264)

Side by Side Diff: public/web/WebFrame.h

Issue 544443002: Detach all subframes before swapping a frame. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Remove ASSERT in detachChildren, since FrameLoader::commitProvisionalLoad can hit it with ref count… Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2009 Google Inc. All rights reserved. 2 * Copyright (C) 2009 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 97 matching lines...) Expand 10 before | Expand all | Expand 10 after
108 typedef unsigned RenderAsTextControls; 108 typedef unsigned RenderAsTextControls;
109 109
110 // Returns the number of live WebFrame objects, used for leak checking. 110 // Returns the number of live WebFrame objects, used for leak checking.
111 BLINK_EXPORT static int instanceCount(); 111 BLINK_EXPORT static int instanceCount();
112 112
113 virtual bool isWebLocalFrame() const = 0; 113 virtual bool isWebLocalFrame() const = 0;
114 virtual WebLocalFrame* toWebLocalFrame() = 0; 114 virtual WebLocalFrame* toWebLocalFrame() = 0;
115 virtual bool isWebRemoteFrame() const = 0; 115 virtual bool isWebRemoteFrame() const = 0;
116 virtual WebRemoteFrame* toWebRemoteFrame() = 0; 116 virtual WebRemoteFrame* toWebRemoteFrame() = 0;
117 117
118 BLINK_EXPORT void swap(WebFrame*); 118 BLINK_EXPORT bool swap(WebFrame*);
119 119
120 // This method closes and deletes the WebFrame. 120 // This method closes and deletes the WebFrame.
121 virtual void close() = 0; 121 virtual void close() = 0;
122 122
123 123
124 // Basic properties --------------------------------------------------- 124 // Basic properties ---------------------------------------------------
125 125
126 // The unique name of this frame. 126 // The unique name of this frame.
127 virtual WebString uniqueName() const = 0; 127 virtual WebString uniqueName() const = 0;
128 128
(...skipping 573 matching lines...) Expand 10 before | Expand all | Expand 10 after
702 WebPrivateOwnPtr<OpenedFrameTracker> m_openedFrameTracker; 702 WebPrivateOwnPtr<OpenedFrameTracker> m_openedFrameTracker;
703 }; 703 };
704 704
705 #if BLINK_IMPLEMENTATION 705 #if BLINK_IMPLEMENTATION
706 Frame* toCoreFrame(const WebFrame*); 706 Frame* toCoreFrame(const WebFrame*);
707 #endif 707 #endif
708 708
709 } // namespace blink 709 } // namespace blink
710 710
711 #endif 711 #endif
OLDNEW
« Source/web/WebFrame.cpp ('K') | « Source/web/tests/data/subframe-b.html ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698