Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(482)

Issue 544263002: Revert of Try backing SkPicture with SkRecord in Chromium. (Closed)

Created:
6 years, 3 months ago by mtklein_C
Modified:
6 years, 3 months ago
CC:
chromium-reviews, Stephen White, robertphillips, Tom Hudson
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Revert of Try backing SkPicture with SkRecord in Chromium. (patchset #4 id:60001 of https://codereview.chromium.org/504823003/) Reason for revert: https://code.google.com/p/chromium/issues/detail?id=411330 Original issue's description: > Try backing SkPicture with SkRecord in Chromium. > > This is our first attempt, mostly to feel this out. Performance and > correctness problems are both possible. Please revert this if a benchmark even > smells funny. > > That said, we've been working on this a while, are pretty confident it's good > stuff, and have had Skia's internal testing entirely switched over for a week. > Parts of Chromium that serialize and deserialize SkPictures are already > switched over. This CL finishes things off by switching the default > recorded-from-scratch SkPicture to use SkRecord too. > > BUG=408985, 409110, 409138, 411330 > > Committed: https://chromium.googlesource.com/chromium/src/+/f7450daaf38f4951b23fabaaaf659c6af33a705c > > Committed: https://chromium.googlesource.com/chromium/src/+/5f2a6ab31313eb2fc6e456f65c3863a77d2d0c30 > > CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg;tryserver.chromium.linux:linux_browser_asan > > Committed: https://chromium.googlesource.com/chromium/src/+/130033d6c732af90ed117f05517e4efffd23ae58 > > Committed: https://chromium.googlesource.com/chromium/src/+/96730ee0419e528d8d3eac360e9319a871d20e43 TBR=reed@google.com,mtklein@google.com,senorblanco@chromium.org,eroman@chromium.org,fmalita@chromium.org NOTREECHECKS=true NOTRY=true BUG=408985, 409110, 409138, 411330 Committed: https://crrev.com/304c5dd1b83765e0575dc91766a3bf8c91c24b96 Cr-Commit-Position: refs/heads/master@{#293544}

Patch Set 1 #

Patch Set 2 : manually rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -6 lines) Patch
M skia/config/SkUserConfig.h View 1 1 chunk +0 lines, -3 lines 0 comments Download
M skia/skia_test_expectations.txt View 1 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 14 (5 generated)
mtklein_C
Created Revert of Try backing SkPicture with SkRecord in Chromium.
6 years, 3 months ago (2014-09-05 16:58:27 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mtklein@chromium.org/544263002/1
6 years, 3 months ago (2014-09-05 17:01:51 UTC) #2
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
6 years, 3 months ago (2014-09-05 17:01:52 UTC) #4
robertphillips
lgtm
6 years, 3 months ago (2014-09-05 17:02:37 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mtklein@chromium.org/544263002/1
6 years, 3 months ago (2014-09-05 17:06:17 UTC) #8
commit-bot: I haz the power
Failed to apply patch for skia/config/SkUserConfig.h: While running git apply --index -p1; error: patch failed: ...
6 years, 3 months ago (2014-09-05 17:07:08 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mtklein@chromium.org/544263002/70001
6 years, 3 months ago (2014-09-05 17:23:04 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:70001) as 52ab8301f90226ffe47c05f16551d96a8521a1ab
6 years, 3 months ago (2014-09-05 17:24:47 UTC) #13
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:40:19 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/304c5dd1b83765e0575dc91766a3bf8c91c24b96
Cr-Commit-Position: refs/heads/master@{#293544}

Powered by Google App Engine
This is Rietveld 408576698