Avoid repeatedly deriving fonts in the LabelButton ctor.

Avoid repeatedly deriving fonts in the LabelButton ctor.

Create LazyInstances for the default LabelButton FontLists.
Avoid creating/deriving default fonts for each new button.
(the bookmark bar can create unbounded button instances)
(repeated derivation is slow and exhausts GDI handles)

BUG=411716
TEST=Profiles with tons of bookmarks do not crash.
R=sky@chromium.org

Committed: https://crrev.com/753f06ff55b91b8ff39352e8bf87cbbbd2d695f4
Cr-Commit-Position: refs/heads/master@{#294955}

[sky, 2014-09-15 19:15:33]

sky@chromium.org changed reviewers:
+ sky@chromium.org

[sky, 2014-09-15 19:15:34]

https://codereview.chromium.org/544173007/diff/20001/ui/views/controls/button...
File ui/views/controls/button/label_button.cc (right):

https://codereview.chromium.org/544173007/diff/20001/ui/views/controls/button...
ui/views/controls/button/label_button.cc:34: static const gfx::FontList
kNormalFontList = gfx::FontList();
Style guide says no statics like this. I think the patch I sent you avoids the
common case we're hitting.

[msw, 2014-09-15 20:51:42]

Please take another look, thanks!

https://codereview.chromium.org/544173007/diff/20001/ui/views/controls/button...
File ui/views/controls/button/label_button.cc (right):

https://codereview.chromium.org/544173007/diff/20001/ui/views/controls/button...
ui/views/controls/button/label_button.cc:34: static const gfx::FontList
kNormalFontList = gfx::FontList();
On 2014/09/15 19:15:34, sky wrote:
> Style guide says no statics like this. I think the patch I sent you avoids the
> common case we're hitting.

Done.

[sky, 2014-09-15 21:39:01]

LGTM

[msw, 2014-09-15 23:11:43]

The CQ bit was checked by msw@chromium.org

[commit-bot: I haz the power, 2014-09-15 23:32:21]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patchset/544173007/60001

[commit-bot: I haz the power, 2014-09-16 01:04:08]

Committed patchset #4 (id:60001) as a340f8846f8247e06ef4675a12d7af49ea302a38

[commit-bot: I haz the power, 2014-09-16 01:06:56]

Patchset 4 (id:??) landed as
https://crrev.com/753f06ff55b91b8ff39352e8bf87cbbbd2d695f4
Cr-Commit-Position: refs/heads/master@{#294955}