Avoid repeatedly deriving fonts in the LabelButton ctor.

ui/views/controls/button/label_button.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ui/views/controls/button/label_button.h"
 
 #include "base/logging.h"
 #include "ui/gfx/animation/throb_animation.h"
 #include "ui/gfx/canvas.h"
 #include "ui/gfx/font_list.h"
@@ skipping 12 matching lines @@
 
 // The default spacing between the icon and text.
 const int kSpacing = 5;
 
 #if !(defined(OS_LINUX) && !defined(OS_CHROMEOS))
 // Default text and shadow colors for STYLE_BUTTON.
 const SkColor kStyleButtonTextColor = SK_ColorBLACK;
 const SkColor kStyleButtonShadowColor = SK_ColorWHITE;
 #endif
 
+const gfx::FontList& GetDefaultNormalFontList() {
+  static const gfx::FontList kNormalFontList = gfx::FontList();

[sky, 2014/09/15 19:15:34]

Style guide says no statics like this. I think the patch I sent you avoids the
common case we're hitting.

[msw, 2014/09/15 20:51:42]

Done.

+  return kNormalFontList;
+}
+
+const gfx::FontList& GetDefaultBoldFontList() {
+  static const gfx::FontList kBoldFontList = gfx::FontList().
+      DeriveWithStyle(gfx::FontList().GetFontStyle() | gfx::Font::BOLD);
+  return kBoldFontList;
+}
+
 }  // namespace
 
 namespace views {
 
 // static
 const int LabelButton::kHoverAnimationDurationMs = 170;
 
 // static
 const char LabelButton::kViewClassName[] = "LabelButton";
 
 LabelButton::LabelButton(ButtonListener* listener, const base::string16& text)
     : CustomButton(listener),
       image_(new ImageView()),
       label_(new Label()),
+      cached_normal_font_list_(GetDefaultNormalFontList()),
+      cached_bold_font_list_(GetDefaultBoldFontList()),
       button_state_images_(),
       button_state_colors_(),
       explicitly_set_colors_(),
       is_default_(false),
       style_(STYLE_TEXTBUTTON),
       border_is_themed_border_(true),
       image_label_spacing_(kSpacing) {
   SetAnimationDuration(kHoverAnimationDurationMs);
   SetText(text);
-  SetFontList(gfx::FontList());
 
   AddChildView(image_);
   image_->set_interactive(false);
 
   AddChildView(label_);
+  label_->SetFontList(cached_normal_font_list_);
   label_->SetAutoColorReadabilityEnabled(false);
   label_->SetHorizontalAlignment(gfx::ALIGN_LEFT);
 
   // Initialize the colors, border, and layout.
   SetStyle(style_);
 
   SetAccessibleName(text);
 }
 
 LabelButton::~LabelButton() {}
@@ skipping 417 matching lines @@
   GetExtraParams(params);
   return ui::NativeTheme::kHovered;
 }
 
 void LabelButton::ResetCachedPreferredSize() {
   cached_preferred_size_valid_ = false;
   cached_preferred_size_= gfx::Size();
 }
 
 }  // namespace views