Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(181)

Issue 544123002: Do not cache CodeStubInterfaceDescriptor on the isolate. (Closed)

Created:
6 years, 3 months ago by Yang
Modified:
6 years, 3 months ago
Reviewers:
mvstanton
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

Do not cache CodeStubInterfaceDescriptor on the isolate. R=mvstanton@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=23744

Patch Set 1 #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+144 lines, -307 lines) Patch
M src/arm/code-stubs-arm.cc View 1 chunk +6 lines, -6 lines 0 comments Download
M src/arm/lithium-arm.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M src/arm64/code-stubs-arm64.cc View 1 chunk +6 lines, -5 lines 0 comments Download
M src/code-stubs.h View 22 chunks +12 lines, -54 lines 1 comment Download
M src/code-stubs.cc View 4 chunks +39 lines, -110 lines 1 comment Download
M src/code-stubs-hydrogen.cc View 6 chunks +15 lines, -19 lines 0 comments Download
M src/compiler/js-generic-lowering.cc View 10 chunks +22 lines, -37 lines 0 comments Download
M src/compiler/linkage.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M src/compiler/raw-machine-assembler.cc View 1 chunk +3 lines, -4 lines 0 comments Download
M src/compiler/simplified-lowering.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M src/deoptimizer.cc View 4 chunks +9 lines, -9 lines 0 comments Download
M src/hydrogen.cc View 1 chunk +4 lines, -3 lines 0 comments Download
M src/ia32/code-stubs-ia32.cc View 1 chunk +6 lines, -6 lines 0 comments Download
M src/ia32/lithium-ia32.cc View 1 chunk +3 lines, -3 lines 1 comment Download
M src/isolate.h View 1 chunk +0 lines, -3 lines 0 comments Download
M src/isolate.cc View 5 chunks +0 lines, -30 lines 0 comments Download
M src/mips/code-stubs-mips.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/x64/code-stubs-x64.cc View 1 chunk +6 lines, -6 lines 0 comments Download
M src/x64/lithium-x64.cc View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Yang
6 years, 3 months ago (2014-09-05 13:08:22 UTC) #1
mvstanton
lgtm https://codereview.chromium.org/544123002/diff/1/src/code-stubs.cc File src/code-stubs.cc (right): https://codereview.chromium.org/544123002/diff/1/src/code-stubs.cc#newcode201 src/code-stubs.cc:201: void CodeStub::Dispatch(Isolate* isolate, uint32_t key, void** value_out, As ...
6 years, 3 months ago (2014-09-05 13:38:44 UTC) #2
Yang
6 years, 3 months ago (2014-09-05 15:21:05 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 23744 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698