Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Side by Side Diff: src/arm/code-stubs-arm.cc

Issue 544123002: Do not cache CodeStubInterfaceDescriptor on the isolate. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | src/arm/lithium-arm.cc » ('j') | src/code-stubs.h » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/v8.h" 5 #include "src/v8.h"
6 6
7 #if V8_TARGET_ARCH_ARM 7 #if V8_TARGET_ARCH_ARM
8 8
9 #include "src/base/bits.h" 9 #include "src/base/bits.h"
10 #include "src/bootstrapper.h" 10 #include "src/bootstrapper.h"
(...skipping 104 matching lines...) Expand 10 before | Expand all | Expand 10 after
115 bool strict); 115 bool strict);
116 static void EmitStrictTwoHeapObjectCompare(MacroAssembler* masm, 116 static void EmitStrictTwoHeapObjectCompare(MacroAssembler* masm,
117 Register lhs, 117 Register lhs,
118 Register rhs); 118 Register rhs);
119 119
120 120
121 void HydrogenCodeStub::GenerateLightweightMiss(MacroAssembler* masm) { 121 void HydrogenCodeStub::GenerateLightweightMiss(MacroAssembler* masm) {
122 // Update the static counter each time a new code stub is generated. 122 // Update the static counter each time a new code stub is generated.
123 isolate()->counters()->code_stubs()->Increment(); 123 isolate()->counters()->code_stubs()->Increment();
124 124
125 CodeStubInterfaceDescriptor* descriptor = GetInterfaceDescriptor(); 125 CodeStubInterfaceDescriptor descriptor;
126 int param_count = descriptor->GetEnvironmentParameterCount(); 126 InitializeInterfaceDescriptor(&descriptor);
127 int param_count = descriptor.GetEnvironmentParameterCount();
127 { 128 {
128 // Call the runtime system in a fresh internal frame. 129 // Call the runtime system in a fresh internal frame.
129 FrameAndConstantPoolScope scope(masm, StackFrame::INTERNAL); 130 FrameAndConstantPoolScope scope(masm, StackFrame::INTERNAL);
130 DCHECK(param_count == 0 || 131 DCHECK(param_count == 0 ||
131 r0.is(descriptor->GetEnvironmentParameterRegister( 132 r0.is(descriptor.GetEnvironmentParameterRegister(param_count - 1)));
132 param_count - 1)));
133 // Push arguments 133 // Push arguments
134 for (int i = 0; i < param_count; ++i) { 134 for (int i = 0; i < param_count; ++i) {
135 __ push(descriptor->GetEnvironmentParameterRegister(i)); 135 __ push(descriptor.GetEnvironmentParameterRegister(i));
136 } 136 }
137 ExternalReference miss = descriptor->miss_handler(); 137 ExternalReference miss = descriptor.miss_handler();
138 __ CallExternalReference(miss, param_count); 138 __ CallExternalReference(miss, param_count);
139 } 139 }
140 140
141 __ Ret(); 141 __ Ret();
142 } 142 }
143 143
144 144
145 void DoubleToIStub::Generate(MacroAssembler* masm) { 145 void DoubleToIStub::Generate(MacroAssembler* masm) {
146 Label out_of_range, only_low, negate, done; 146 Label out_of_range, only_low, negate, done;
147 Register input_reg = source(); 147 Register input_reg = source();
(...skipping 4531 matching lines...) Expand 10 before | Expand all | Expand 10 after
4679 MemOperand(fp, 6 * kPointerSize), 4679 MemOperand(fp, 6 * kPointerSize),
4680 NULL); 4680 NULL);
4681 } 4681 }
4682 4682
4683 4683
4684 #undef __ 4684 #undef __
4685 4685
4686 } } // namespace v8::internal 4686 } } // namespace v8::internal
4687 4687
4688 #endif // V8_TARGET_ARCH_ARM 4688 #endif // V8_TARGET_ARCH_ARM
OLDNEW
« no previous file with comments | « no previous file | src/arm/lithium-arm.cc » ('j') | src/code-stubs.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698