LayoutTests/fast/borders/border-image-width-numbers-computed-style.html - Issue 54383006: Lift integer restriction on border-image-width and border-image-outset

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/fast/borders/border-image-width-numbers-computed-style.html

Issue 54383006: Lift integer restriction on border-image-width and border-image-outset (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@length-relative-die-step-4-4

Patch Set: Rebase and simplify test Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 <!doctype html>

	2 <html>

	3 <head>

	4 <script src="../../resources/js-test.js"></script>

	5 <style>

	6 .test {

	7 border-image-width: 0 5.5 4.4 3.3;

	8 border-image-outset: 2.5 0 1.4 1.9;

	9 border-style: solid;

	10 visibility: hidden;

	11 }

	12 </style>

	13 </head>

	14 <body>
	Julien - ping for review 2013/11/12 00:34:00 There should be a description of what you are test There should be a description of what you are testing (e.g. This test checks that setting border-image-width to a number is handled correctly). davve 2013/11/12 10:47:06 OK. Show quoted text On 2013/11/12 00:34:00, Julien Chaffraix - AEDT wrote: > There should be a description of what you are testing (e.g. This test checks > that setting border-image-width to a number is handled correctly). OK.
	15 <div class="test"></div>

	16 <script>

	17 var elm = getComputedStyle(document.querySelector('.test'));

	18 shouldBeEqualToString("elm.borderImageWidth", "0 5.5 4.4 3.3");

	19 shouldBeEqualToString("elm.borderImageOutset", "2.5 0 1.4 1.9");
	Julien - ping for review 2013/11/12 00:34:00 While this is great to make this test text-only (< While this is great to make this test text-only (<3), do we have some coverage that we are actually rendering the decimal numbers correctly? Maybe going so far as to test the rounding behavior. davve 2013/11/12 10:47:06 Re-added my rendering reftest. Not sure how to tes Show quoted text On 2013/11/12 00:34:00, Julien Chaffraix - AEDT wrote: > While this is great to make this test text-only (<3), do we have some coverage > that we are actually rendering the decimal numbers correctly? Maybe going so far > as to test the rounding behavior. Re-added my rendering reftest. Not sure how to test rounding behavior yet, but I've made a note about it for follow-up.
	20 </script>

	21 </body>

	22 </html>

OLD	NEW

« no previous file with comments | « no previous file | LayoutTests/fast/borders/border-image-width-numbers-computed-style-expected.txt » ('j') | Source/core/css/CSSParser-in.cpp » ('J')