Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(126)

Issue 54373013: Expose <dialog> in the accessibility tree by default. (Closed)

Created:
7 years, 1 month ago by falken
Modified:
7 years, 1 month ago
Reviewers:
dmazzoni
CC:
blink-reviews, dmazzoni, aboxhall
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Expose <dialog> in the accessibility tree by default. This way accessibility technology can be aware of the dialog. Previously, the 'dialog' role was ignored by default. The test for this patch is on Chrome side: https://codereview.chromium.org/55763002/ BUG=264959 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=161174

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M Source/core/accessibility/AXRenderObject.cpp View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
falken
7 years, 1 month ago (2013-11-01 14:55:02 UTC) #1
dmazzoni
lgtm
7 years, 1 month ago (2013-11-01 15:06:19 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/falken@chromium.org/54373013/1
7 years, 1 month ago (2013-11-01 15:06:40 UTC) #3
commit-bot: I haz the power
7 years, 1 month ago (2013-11-01 16:09:25 UTC) #4
Message was sent while issue was closed.
Change committed as 161174

Powered by Google App Engine
This is Rietveld 408576698