Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(88)

Side by Side Diff: Source/core/accessibility/AXRenderObject.cpp

Issue 54373013: Expose <dialog> in the accessibility tree by default. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2008 Apple Inc. All rights reserved. 2 * Copyright (C) 2008 Apple Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 7 *
8 * 1. Redistributions of source code must retain the above copyright 8 * 1. Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * 2. Redistributions in binary form must reproduce the above copyright 10 * 2. Redistributions in binary form must reproduce the above copyright
(...skipping 694 matching lines...) Expand 10 before | Expand all | Expand 10 after
705 // Anything that is content editable should not be ignored. 705 // Anything that is content editable should not be ignored.
706 // However, one cannot just call node->rendererIsEditable() since that will ask if its parents 706 // However, one cannot just call node->rendererIsEditable() since that will ask if its parents
707 // are also editable. Only the top level content editable region should be e xposed. 707 // are also editable. Only the top level content editable region should be e xposed.
708 if (hasContentEditableAttributeSet()) 708 if (hasContentEditableAttributeSet())
709 return false; 709 return false;
710 710
711 // List items play an important role in defining the structure of lists. The y should not be ignored. 711 // List items play an important role in defining the structure of lists. The y should not be ignored.
712 if (roleValue() == ListItemRole) 712 if (roleValue() == ListItemRole)
713 return false; 713 return false;
714 714
715 if (roleValue() == DialogRole)
716 return false;
717
715 // if this element has aria attributes on it, it should not be ignored. 718 // if this element has aria attributes on it, it should not be ignored.
716 if (supportsARIAAttributes()) 719 if (supportsARIAAttributes())
717 return false; 720 return false;
718 721
719 // <span> tags are inline tags and not meant to convey information if they h ave no other aria 722 // <span> tags are inline tags and not meant to convey information if they h ave no other aria
720 // information on them. If we don't ignore them, they may emit signals expec ted to come from 723 // information on them. If we don't ignore them, they may emit signals expec ted to come from
721 // their parent. In addition, because included spans are GroupRole objects, and GroupRole 724 // their parent. In addition, because included spans are GroupRole objects, and GroupRole
722 // objects are often containers with meaningful information, the inclusion o f a span can have 725 // objects are often containers with meaningful information, the inclusion o f a span can have
723 // the side effect of causing the immediate parent accessible to be ignored. This is especially 726 // the side effect of causing the immediate parent accessible to be ignored. This is especially
724 // problematic for platforms which have distinct roles for textual block ele ments. 727 // problematic for platforms which have distinct roles for textual block ele ments.
(...skipping 1667 matching lines...) Expand 10 before | Expand all | Expand 10 after
2392 if (label && label->renderer()) { 2395 if (label && label->renderer()) {
2393 LayoutRect labelRect = axObjectCache()->getOrCreate(label)->elementR ect(); 2396 LayoutRect labelRect = axObjectCache()->getOrCreate(label)->elementR ect();
2394 result.unite(labelRect); 2397 result.unite(labelRect);
2395 } 2398 }
2396 } 2399 }
2397 2400
2398 return result; 2401 return result;
2399 } 2402 }
2400 2403
2401 } // namespace WebCore 2404 } // namespace WebCore
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698