chrome/chrome_nibs.gyp - Issue 543663002: Componentize sad_tab

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/chrome_nibs.gyp

Issue 543663002: Componentize sad_tab (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix url_constants.cc Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/chrome_nibs.gyp

diff --git a/chrome/chrome_nibs.gyp b/chrome/chrome_nibs.gyp

index f0ea18fbeb174caffab9cc38172f05639781cd73..406205d8dd0e39ae59bd06cae8a83e12cfa37ff5 100644

--- a/chrome/chrome_nibs.gyp

+++ b/chrome/chrome_nibs.gyp

@@ -37,6 +37,10 @@

'../third_party/google_toolbox_for_mac/google_toolbox_for_mac.gyp:google_toolbox_for_mac',

'sources': [

+ '../components/sad_tab/cocoa/sad_tab_controller.h',

+ '../components/sad_tab/cocoa/sad_tab_controller.mm',

+ '../components/sad_tab/cocoa/sad_tab_view.h',

+ '../components/sad_tab/cocoa/sad_tab_view.mm',

'../ui/base/cocoa/base_view.h',

'../ui/base/cocoa/base_view.mm',

'../ui/base/cocoa/controls/hyperlink_button_cell.h',

@@ -199,10 +203,6 @@

'browser/ui/cocoa/styled_text_field_cell.mm',

'browser/ui/cocoa/tab_contents/overlayable_contents_controller.h',

'browser/ui/cocoa/tab_contents/overlayable_contents_controller.mm',

- 'browser/ui/cocoa/tab_contents/sad_tab_controller.h',

- 'browser/ui/cocoa/tab_contents/sad_tab_controller.mm',

- 'browser/ui/cocoa/tab_contents/sad_tab_view.h',

- 'browser/ui/cocoa/tab_contents/sad_tab_view.mm',

'browser/ui/cocoa/tabs/tab_controller.h',

'browser/ui/cocoa/tabs/tab_controller.mm',

'browser/ui/cocoa/tabs/tab_strip_model_observer_bridge.h',

« no previous file with comments | « chrome/chrome_browser_ui.gypi ('k') | chrome/chrome_tests_unit.gypi » ('j') | no next file with comments »