Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(165)

Unified Diff: chrome/chrome_browser_ui.gypi

Issue 543663002: Componentize sad_tab (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix url_constants.cc Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/zoom/zoom_controller.cc ('k') | chrome/chrome_nibs.gyp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/chrome_browser_ui.gypi
diff --git a/chrome/chrome_browser_ui.gypi b/chrome/chrome_browser_ui.gypi
index 9bb9704cb242379ecbdc9fadac9d506cbde8faa1..ae766b9d92143f314685cf88ffe90f87b2b80eba 100644
--- a/chrome/chrome_browser_ui.gypi
+++ b/chrome/chrome_browser_ui.gypi
@@ -689,10 +689,6 @@
'browser/ui/cocoa/tab_contents/favicon_util_mac.mm',
'browser/ui/cocoa/tab_contents/overlayable_contents_controller.h',
'browser/ui/cocoa/tab_contents/overlayable_contents_controller.mm',
- 'browser/ui/cocoa/tab_contents/sad_tab_controller.h',
- 'browser/ui/cocoa/tab_contents/sad_tab_controller.mm',
- 'browser/ui/cocoa/tab_contents/sad_tab_view.h',
- 'browser/ui/cocoa/tab_contents/sad_tab_view.mm',
'browser/ui/cocoa/tab_contents/tab_contents_controller.h',
'browser/ui/cocoa/tab_contents/tab_contents_controller.mm',
'browser/ui/cocoa/tab_contents/web_drag_bookmark_handler_mac.h',
@@ -1398,6 +1394,8 @@
'browser/ui/browser_view_prefs.h',
'browser/ui/chrome_pages.cc',
'browser/ui/chrome_pages.h',
+ 'browser/ui/chrome_sad_tab_client.cc',
+ 'browser/ui/chrome_sad_tab_client.h',
'browser/ui/chrome_style.cc',
'browser/ui/chrome_style.h',
'browser/ui/chrome_web_modal_dialog_manager_delegate.cc',
@@ -1497,11 +1495,6 @@
'browser/ui/pdf/chrome_pdf_web_contents_helper_client.h',
'browser/ui/pdf/pdf_unsupported_feature.cc',
'browser/ui/pdf/pdf_unsupported_feature.h',
- 'browser/ui/sad_tab.cc',
- 'browser/ui/sad_tab.h',
- 'browser/ui/sad_tab_helper.cc',
- 'browser/ui/sad_tab_helper.h',
- 'browser/ui/sad_tab_types.h',
'browser/ui/search/search_delegate.cc',
'browser/ui/search/search_delegate.h',
'browser/ui/search/search_ui.cc',
@@ -2175,8 +2168,6 @@
'browser/ui/views/profiles/user_manager_view.h',
'browser/ui/views/renderer_context_menu/render_view_context_menu_views.cc',
'browser/ui/views/renderer_context_menu/render_view_context_menu_views.h',
- 'browser/ui/views/sad_tab_view.cc',
- 'browser/ui/views/sad_tab_view.h',
'browser/ui/views/session_crashed_bubble_view.cc',
'browser/ui/views/session_crashed_bubble_view.h',
'browser/ui/views/settings_api_bubble_helper_views.cc',
@@ -2803,6 +2794,9 @@
],
'sources': [ '<@(chrome_browser_ui_android_sources)' ],
}, { # Non-Android
+ 'dependencies': [
+ '../components/components.gyp:sad_tab',
+ ],
'sources': [ '<@(chrome_browser_ui_non_android_sources)' ],
}],
['OS=="mac"', {
« no previous file with comments | « chrome/browser/ui/zoom/zoom_controller.cc ('k') | chrome/chrome_nibs.gyp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698