Componentize sad_tab

components/sad_tab/url_constants.cc

Index: components/sad_tab/url_constants.cc
diff --git a/components/sad_tab/url_constants.cc b/components/sad_tab/url_constants.cc
new file mode 100644
index 0000000000000000000000000000000000000000..1188fb7b77ab13af4e25570b39c767b3c90f063c
--- /dev/null
+++ b/components/sad_tab/url_constants.cc
@@ -0,0 +1,23 @@
+// Copyright 2014 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "components/sad_tab/url_constants.h"
+
+namespace sad_tab {
+
+const char kCrashReasonURL[] =
+#if defined(OS_CHROMEOS)
+    "https://support.google.com/chromeos/?p=e_awsnap";
+#else
+    "https://support.google.com/chrome/?p=e_awsnap";
+#endif
+
+const char kKillReasonURL[] =
+#if defined(OS_CHROMEOS)
+    "https://support.google.com/chromeos/?p=e_deadjim";
+#else
+    "https://support.google.com/chrome/?p=e_deadjim";
+#endif
+

[sadrul, 2014/09/22 16:48:22]

An alternate for this is:

#if defined(OS_CHROMEOS)
#define PRODUCT_PATH "chromeos"
#else
#define PRODUCT_PATH "chrome"
#endif

const char kCrashReasonURL[] =
    "https://support.google.com/" PRODUCT_PATH "/?p=e_awsnap";
const char kKillReasonURL[] =
    "https://support.google.com/" PRODUCT_PATH "/?p=e_deadjim";

[hashimoto, 2014/09/26 08:43:35]

Done.

+}  // namespace sad_tab