components/sad_tab/url_constants.cc - Issue 543663002: Componentize sad_tab

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: components/sad_tab/url_constants.cc

Issue 543663002: Componentize sad_tab (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix GN Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 // Copyright 2014 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #include "components/sad_tab/url_constants.h"

	6

	7 namespace sad_tab {

	8

	9 const char kCrashReasonURL[] =

	10 #if defined(OS_CHROMEOS)

	11 "https://support.google.com/chromeos/?p=e_awsnap";

	12 #else

	13 "https://support.google.com/chrome/?p=e_awsnap";

	14 #endif

	15

	16 const char kKillReasonURL[] =

	17 #if defined(OS_CHROMEOS)

	18 "https://support.google.com/chromeos/?p=e_deadjim";

	19 #else

	20 "https://support.google.com/chrome/?p=e_deadjim";

	21 #endif

	22
	sadrul 2014/09/22 16:48:22 An alternate for this is: #if defined(OS_CHROMEOS An alternate for this is: #if defined(OS_CHROMEOS) #define PRODUCT_PATH "chromeos" #else #define PRODUCT_PATH "chrome" #endif const char kCrashReasonURL[] = "https://support.google.com/" PRODUCT_PATH "/?p=e_awsnap"; const char kKillReasonURL[] = "https://support.google.com/" PRODUCT_PATH "/?p=e_deadjim"; hashimoto 2014/09/26 08:43:35 Done. Show quoted text On 2014/09/22 16:48:22, sadrul wrote: > An alternate for this is: > > #if defined(OS_CHROMEOS) > #define PRODUCT_PATH "chromeos" > #else > #define PRODUCT_PATH "chrome" > #endif > > const char kCrashReasonURL[] = > "https://support.google.com/" PRODUCT_PATH "/?p=e_awsnap"; > const char kKillReasonURL[] = > "https://support.google.com/" PRODUCT_PATH "/?p=e_deadjim"; Done.
	23 } // namespace sad_tab

OLD	NEW