Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(239)

Unified Diff: chrome/chrome_browser_ui.gypi

Issue 543663002: Componentize sad_tab (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/chrome_browser_ui.gypi
diff --git a/chrome/chrome_browser_ui.gypi b/chrome/chrome_browser_ui.gypi
index 235ce1b06abb469e424073e79e8f1061507c0c3d..79b19d8090c80cd3dcdea12b1536833780e922dc 100644
--- a/chrome/chrome_browser_ui.gypi
+++ b/chrome/chrome_browser_ui.gypi
@@ -1410,6 +1410,8 @@
'browser/ui/browser_view_prefs.h',
'browser/ui/chrome_pages.cc',
'browser/ui/chrome_pages.h',
+ 'browser/ui/chrome_sad_tab_client.cc',
+ 'browser/ui/chrome_sad_tab_client.h',
'browser/ui/chrome_style.cc',
'browser/ui/chrome_style.h',
'browser/ui/chrome_web_modal_dialog_manager_delegate.cc',
@@ -1505,11 +1507,6 @@
'browser/ui/pdf/chrome_pdf_web_contents_helper_client.h',
'browser/ui/pdf/pdf_unsupported_feature.cc',
'browser/ui/pdf/pdf_unsupported_feature.h',
- 'browser/ui/sad_tab.cc',
- 'browser/ui/sad_tab.h',
- 'browser/ui/sad_tab_helper.cc',
- 'browser/ui/sad_tab_helper.h',
- 'browser/ui/sad_tab_types.h',
'browser/ui/search/search_delegate.cc',
'browser/ui/search/search_delegate.h',
'browser/ui/search/search_ui.cc',
@@ -2190,8 +2187,6 @@
'browser/ui/views/profiles/user_manager_view.h',
'browser/ui/views/renderer_context_menu/render_view_context_menu_views.cc',
'browser/ui/views/renderer_context_menu/render_view_context_menu_views.h',
- 'browser/ui/views/sad_tab_view.cc',
- 'browser/ui/views/sad_tab_view.h',
'browser/ui/views/session_crashed_bubble_view.cc',
'browser/ui/views/session_crashed_bubble_view.h',
'browser/ui/views/settings_api_bubble_helper_views.cc',
@@ -2811,6 +2806,9 @@
],
'sources': [ '<@(chrome_browser_ui_android_sources)' ],
}, { # Non-Android
+ 'dependencies': [
+ '../components/components.gyp:sad_tab',
+ ],
'sources': [ '<@(chrome_browser_ui_non_android_sources)' ],
}],
['OS=="mac"', {

Powered by Google App Engine
This is Rietveld 408576698