Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(249)

Unified Diff: chrome/browser/ui/tab_helpers.cc

Issue 543663002: Componentize sad_tab (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/tab_helpers.cc
diff --git a/chrome/browser/ui/tab_helpers.cc b/chrome/browser/ui/tab_helpers.cc
index 797bb3af6cc18848227beabf3ff625276421d288..a226c4963f07c3ace394c2441731b1724a59e3f9 100644
--- a/chrome/browser/ui/tab_helpers.cc
+++ b/chrome/browser/ui/tab_helpers.cc
@@ -42,14 +42,15 @@
#include "chrome/browser/plugins/plugin_observer.h"
#include "chrome/browser/safe_browsing/safe_browsing_tab_observer.h"
#include "chrome/browser/thumbnails/thumbnail_tab_helper.h"
+#include "chrome/browser/ui/chrome_sad_tab_client.h"
#include "chrome/browser/ui/hung_plugin_tab_helper.h"
#include "chrome/browser/ui/passwords/manage_passwords_ui_controller.h"
-#include "chrome/browser/ui/sad_tab_helper.h"
#include "chrome/browser/ui/search_engines/search_engine_tab_helper.h"
#include "chrome/browser/ui/sync/tab_contents_synced_tab_delegate.h"
#include "chrome/browser/ui/website_settings/permission_bubble_manager.h"
#include "chrome/browser/ui/zoom/zoom_controller.h"
#include "components/pdf/browser/pdf_web_contents_helper.h"
+#include "components/sad_tab/sad_tab_helper.h"
#include "components/web_modal/web_contents_modal_dialog_manager.h"
#endif // defined(OS_ANDROID)
@@ -171,7 +172,8 @@ void TabHelpers::AttachTabHelpers(WebContents* web_contents) {
new ChromePDFWebContentsHelperClient()));
PermissionBubbleManager::CreateForWebContents(web_contents);
PluginObserver::CreateForWebContents(web_contents);
- SadTabHelper::CreateForWebContents(web_contents);
+ sad_tab::SadTabHelper::CreateForWebContentsWithClient(
+ web_contents, scoped_ptr<sad_tab::SadTabClient>(new ChromeSadTabClient));
safe_browsing::SafeBrowsingTabObserver::CreateForWebContents(web_contents);
SearchEngineTabHelper::CreateForWebContents(web_contents);
TabContentsSyncedTabDelegate::CreateForWebContents(web_contents);

Powered by Google App Engine
This is Rietveld 408576698