Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Issue 543643003: ozone: Plumb animated cursors from BitmapCursorFactoryOzone to DriSurfaceFactory (Closed)

Created:
6 years, 3 months ago by spang
Modified:
6 years, 3 months ago
Reviewers:
kenrb, dnicoara
CC:
chromium-reviews, rjkroege, piman+watch_chromium.org, ozone-reviews_chromium.org, kalyank
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

ozone: Plumb animated cursors from BitmapCursorFactoryOzone to DriSurfaceFactory Update BitmapCursorOzone type to store a vector of bitmaps, a hotspot, and a frame delay. Plumb the vector through to the GPU process, where we'll update the cursor on a timer. This is plumbing only; it does not change the user-visible behavior of showing only the first cursor frame. R=dnicoara, kenrb BUG=343245 TEST=viewed css "wait" cursor on cros link_freon Committed: https://crrev.com/ba21e464cf9388db1713605b6dfac70689eb2f4c Cr-Commit-Position: refs/heads/master@{#294045}

Patch Set 1 #

Total comments: 2

Patch Set 2 : rebase & readd virtual #

Patch Set 3 : just clang Werrors #

Patch Set 4 : fix dri_surface_factory_unittest #

Unified diffs Side-by-side diffs Delta from patch set Stats (+109 lines, -38 lines) Patch
M ui/base/cursor/ozone/bitmap_cursor_factory_ozone.h View 1 2 1 chunk +13 lines, -6 lines 0 comments Download
M ui/base/cursor/ozone/bitmap_cursor_factory_ozone.cc View 1 2 2 chunks +37 lines, -2 lines 0 comments Download
M ui/ozone/common/gpu/ozone_gpu_messages.h View 1 chunk +5 lines, -2 lines 0 comments Download
M ui/ozone/platform/dri/dri_cursor.h View 1 chunk +2 lines, -0 lines 0 comments Download
M ui/ozone/platform/dri/dri_cursor.cc View 1 2 chunks +11 lines, -4 lines 0 comments Download
M ui/ozone/platform/dri/dri_surface_factory.h View 1 2 chunks +6 lines, -4 lines 0 comments Download
M ui/ozone/platform/dri/dri_surface_factory.cc View 2 chunks +10 lines, -5 lines 0 comments Download
M ui/ozone/platform/dri/dri_surface_factory_unittest.cc View 1 2 3 1 chunk +6 lines, -2 lines 0 comments Download
M ui/ozone/platform/dri/gpu_platform_support_gbm.h View 1 chunk +3 lines, -2 lines 0 comments Download
M ui/ozone/platform/dri/gpu_platform_support_gbm.cc View 1 chunk +4 lines, -3 lines 0 comments Download
M ui/ozone/platform/dri/gpu_platform_support_host_gbm.h View 1 chunk +3 lines, -2 lines 0 comments Download
M ui/ozone/platform/dri/gpu_platform_support_host_gbm.cc View 1 chunk +6 lines, -4 lines 0 comments Download
M ui/ozone/platform/dri/hardware_cursor_delegate.h View 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (1 generated)
spang
+dnicoara +kenrb for ozone_gpu_messages.h depends on https://codereview.chromium.org/543823002/
6 years, 3 months ago (2014-09-04 20:25:20 UTC) #1
dnicoara
lgtm with the following change https://codereview.chromium.org/543643003/diff/1/ui/ozone/platform/dri/dri_surface_factory.h File ui/ozone/platform/dri/dri_surface_factory.h (right): https://codereview.chromium.org/543643003/diff/1/ui/ozone/platform/dri/dri_surface_factory.h#newcode57 ui/ozone/platform/dri/dri_surface_factory.h:57: void SetHardwareCursor(gfx::AcceleratedWidget widget, re-add ...
6 years, 3 months ago (2014-09-04 20:44:51 UTC) #2
kenrb
ipc lgtm
6 years, 3 months ago (2014-09-05 18:54:40 UTC) #3
spang
https://codereview.chromium.org/543643003/diff/1/ui/ozone/platform/dri/dri_surface_factory.h File ui/ozone/platform/dri/dri_surface_factory.h (right): https://codereview.chromium.org/543643003/diff/1/ui/ozone/platform/dri/dri_surface_factory.h#newcode57 ui/ozone/platform/dri/dri_surface_factory.h:57: void SetHardwareCursor(gfx::AcceleratedWidget widget, On 2014/09/04 20:44:51, dnicoara wrote: > ...
6 years, 3 months ago (2014-09-09 20:19:44 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/spang@chromium.org/543643003/60001
6 years, 3 months ago (2014-09-09 23:06:06 UTC) #6
commit-bot: I haz the power
Committed patchset #4 (id:60001) as 61cd6bf9f924668b9b8da6b4a9fe9f4f6a0ecf3d
6 years, 3 months ago (2014-09-10 00:11:33 UTC) #7
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:56:48 UTC) #8
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/ba21e464cf9388db1713605b6dfac70689eb2f4c
Cr-Commit-Position: refs/heads/master@{#294045}

Powered by Google App Engine
This is Rietveld 408576698