Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(205)

Unified Diff: src/gpu/gl/builders/GrGLVertexShaderBuilder.h

Issue 543623004: Removing vertex attrib indices (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: warning fixed Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/gpu/gl/builders/GrGLShaderBuilder.h ('k') | src/gpu/gl/builders/GrGLVertexShaderBuilder.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/gpu/gl/builders/GrGLVertexShaderBuilder.h
diff --git a/src/gpu/gl/builders/GrGLVertexShaderBuilder.h b/src/gpu/gl/builders/GrGLVertexShaderBuilder.h
index c576f5788210ddabf7eb2f371a90ef1a520aee3b..434e7e63c6c2347483ed2655d7f792c6eae236e2 100644
--- a/src/gpu/gl/builders/GrGLVertexShaderBuilder.h
+++ b/src/gpu/gl/builders/GrGLVertexShaderBuilder.h
@@ -16,14 +16,6 @@ public:
GrGLVertexShaderBuilder(GrGLFullProgramBuilder* program);
/*
- * Add attribute will push a new attribute onto the end. It will also assert if there is
- * a duplicate attribute
- */
- bool addAttribute(GrSLType type, const char* name);
-
- bool addEffectAttribute(int attributeIndex, GrSLType type, const SkString& name);
-
- /*
* this call is only for GrGLProgramEffects' internal use
*/
void emitAttributes(const GrEffectStage& stage);
@@ -47,6 +39,12 @@ public:
private:
/*
+ * Add attribute will push a new attribute onto the end. It will also assert if there is
+ * a duplicate attribute
+ */
+ bool addAttribute(const GrShaderVar& var);
+
+ /*
* Internal call for GrGLFullProgramBuilder.addVarying
*/
void addVarying(GrSLType type,
@@ -69,9 +67,9 @@ private:
SkString fName;
};
- SkSTArray<10, AttributePair, true> fEffectAttributes;
GrGLShaderVar* fPositionVar;
GrGLShaderVar* fLocalCoordsVar;
+ int fEffectAttribOffset;
friend class GrGLFullProgramBuilder;
« no previous file with comments | « src/gpu/gl/builders/GrGLShaderBuilder.h ('k') | src/gpu/gl/builders/GrGLVertexShaderBuilder.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698