Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(690)

Unified Diff: ui/webui/resources/js/cr/ui/grid.js

Issue 543493002: Compile chrome://settings, part 2: reduce from 950 to 400 errors (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@F_settings
Patch Set: rebase? rebase! Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/webui/resources/js/cr/ui/grid.js
diff --git a/ui/webui/resources/js/cr/ui/grid.js b/ui/webui/resources/js/cr/ui/grid.js
index ecfc56eb580220be567b0cfef1573cedadc1e911..54ca960ce8bdb65c975b4b601311e53dd903697e 100644
--- a/ui/webui/resources/js/cr/ui/grid.js
+++ b/ui/webui/resources/js/cr/ui/grid.js
@@ -37,7 +37,7 @@ cr.define('cr.ui', function() {
* Called when an element is decorated as a grid item.
*/
decorate: function() {
- ListItem.prototype.decorate.call(this, arguments);
+ ListItem.prototype.decorate.apply(this, arguments);
this.textContent = this.dataItem;
}
};
@@ -63,7 +63,7 @@ cr.define('cr.ui', function() {
/**
* Function used to create grid items.
- * @type {function(): !GridItem}
+ * @type {function(new:cr.ui.GridItem, Object)}
* @override
*/
itemConstructor_: GridItem,
@@ -250,13 +250,12 @@ cr.define('cr.ui', function() {
* puts spacers on the right places.
* @param {number} firstIndex The index of first item, inclusively.
* @param {number} lastIndex The index of last item, exclusively.
- * @param {Object.<string, ListItem>} cachedItems Old items cache.
- * @param {Object.<string, ListItem>} newCachedItems New items cache.
+ * @param {Object.<string, cr.ui.ListItem>} cachedItems Old items cache.
+ * @param {Object.<string, cr.ui.ListItem>} newCachedItems New items cache.
* @override
*/
mergeItems: function(firstIndex, lastIndex, cachedItems, newCachedItems) {
- List.prototype.mergeItems.call(this,
- firstIndex, lastIndex, cachedItems, newCachedItems);
+ List.prototype.mergeItems.call(this, firstIndex, lastIndex);
var afterFiller = this.afterFiller_;
var columns = this.columns;
@@ -342,7 +341,7 @@ cr.define('cr.ui', function() {
* interact with.
* @param {cr.ui.Grid} grid The grid to interact with.
* @constructor
- * @extends {!cr.ui.ListSelectionController}
+ * @extends {cr.ui.ListSelectionController}
*/
function GridSelectionController(selectionModel, grid) {
this.selectionModel_ = selectionModel;
« no previous file with comments | « ui/webui/resources/js/cr/ui/bubble_button.js ('k') | ui/webui/resources/js/cr/ui/list_single_selection_model.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698