Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(495)

Unified Diff: ui/webui/resources/js/cr/ui/bubble_button.js

Issue 543493002: Compile chrome://settings, part 2: reduce from 950 to 400 errors (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@F_settings
Patch Set: rebase? rebase! Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ui/webui/resources/js/cr/ui/autocomplete_list.js ('k') | ui/webui/resources/js/cr/ui/grid.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/webui/resources/js/cr/ui/bubble_button.js
diff --git a/ui/webui/resources/js/cr/ui/bubble_button.js b/ui/webui/resources/js/cr/ui/bubble_button.js
index 7216a2d4180b32e434a2e65d2aafec4875084eb6..fa1d8a88b31e80988a183a38abe80236397f98b1 100644
--- a/ui/webui/resources/js/cr/ui/bubble_button.js
+++ b/ui/webui/resources/js/cr/ui/bubble_button.js
@@ -8,6 +8,7 @@ cr.define('cr.ui', function() {
* keyboard or mouse.
* @constructor
* @extends {HTMLSpanElement}
+ * @implements {EventListener}
*/
var BubbleButton = cr.ui.define('span');
@@ -71,10 +72,19 @@ cr.define('cr.ui', function() {
event.preventDefault();
return;
}
- this.toggleBubble_();
+ this.toggleBubble();
event.preventDefault();
event.stopPropagation();
},
+
+ /**
+ * Abstract method: subclasses should overwrite it. There is no way to mark
+ * method as abstract for Closure Compiler, as of
+ * https://github.com/google/closure-compiler/issues/104.
+ * @type {!Function|undefined}
+ * @protected
+ */
+ toggleBubble: assertNotReached,
};
// Export.
« no previous file with comments | « ui/webui/resources/js/cr/ui/autocomplete_list.js ('k') | ui/webui/resources/js/cr/ui/grid.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698