Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2858)

Unified Diff: chrome/browser/resources/options/font_settings.js

Issue 543493002: Compile chrome://settings, part 2: reduce from 950 to 400 errors (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@F_settings
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/options/font_settings.js
diff --git a/chrome/browser/resources/options/font_settings.js b/chrome/browser/resources/options/font_settings.js
index 84982d31eb45402bdeb3567501ceb62ac38bf14b..90deb32e1883a7ce658bcc935a9016dc50c3bc6b 100644
--- a/chrome/browser/resources/options/font_settings.js
+++ b/chrome/browser/resources/options/font_settings.js
@@ -155,7 +155,8 @@ cr.define('options', function() {
* @param {Element} el The div containing the sample text.
* @param {number} size The font size of the sample text.
* @param {string} font The font family of the sample text.
- * @param {bool} showSize True if the font size should appear in the sample.
+ * @param {boolean} showSize True if the font size should appear in the
+ * sample.
* @private
*/
setUpFontSample_: function(el, size, font, showSize) {
@@ -179,7 +180,7 @@ cr.define('options', function() {
element.textContent = '';
// Insert new child nodes into select element.
- var value, text, selected, option;
+ var value, text, dir, selected, option;
for (var i = 0; i < items.length; i++) {
value = items[i][0];
Dan Beam 2014/09/06 02:22:36 nit: I'd say just put var instead here, i.e. va
Vitaly Pavlenko 2014/09/06 22:54:08 Done.
text = items[i][1];

Powered by Google App Engine
This is Rietveld 408576698