Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(107)

Unified Diff: chrome/browser/resources/options/content_settings_exceptions_area.js

Issue 543493002: Compile chrome://settings, part 2: reduce from 950 to 400 errors (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@F_settings
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/options/content_settings_exceptions_area.js
diff --git a/chrome/browser/resources/options/content_settings_exceptions_area.js b/chrome/browser/resources/options/content_settings_exceptions_area.js
index 2279c197c523490163be3eea58d60970ba39edba..3bbd4fea260ee723156b5520c0fb6da9c7d715ae 100644
--- a/chrome/browser/resources/options/content_settings_exceptions_area.js
+++ b/chrome/browser/resources/options/content_settings_exceptions_area.js
@@ -178,7 +178,7 @@ cr.define('options.contentSettings', function() {
if (controlledBy == 'policy' || controlledBy == 'extension') {
this.querySelector('.row-delete-button').hidden = true;
- var indicator = ControlledSettingIndicator();
+ var indicator = new ControlledSettingIndicator();
indicator.setAttribute('content-exception', this.contentType);
// Create a synthetic pref change event decorated as
// CoreOptionsHandler::CreateValueForPref() does.
@@ -231,8 +231,6 @@ cr.define('options.contentSettings', function() {
return loadTimeData.getStringF('embeddedOnHost',
this.dataItem.embeddingOrigin);
}
-
- return this.dataItem.displayPattern;
},
set pattern(pattern) {
if (!this.editable)
@@ -400,7 +398,7 @@ cr.define('options.contentSettings', function() {
* @param {boolean} enableAskOption Whether to show an 'ask every time' option
* in the select.
* @constructor
- * @extends {cr.ui.ExceptionsListItem}
+ * @extends {options.contentSettings.ExceptionsListItem}
*/
function ExceptionsAddRowListItem(contentType, mode, enableAskOption) {
var el = cr.doc.createElement('div');
@@ -533,7 +531,7 @@ cr.define('options.contentSettings', function() {
* item to reflect this.
*
* @param {string} pattern The pattern.
- * @param {bool} valid Whether said pattern is valid in the context of a
+ * @param {boolean} valid Whether said pattern is valid in the context of a
* content exception setting.
*/
patternValidityCheckComplete: function(pattern, valid) {
@@ -596,6 +594,7 @@ cr.define('options.contentSettings', function() {
* Encapsulated handling of content settings list subpage.
*
* @constructor
+ * @extends {cr.ui.pageManager.Page}
*/
function ContentSettingsExceptionsArea() {
Page.call(this, 'contentExceptions',

Powered by Google App Engine
This is Rietveld 408576698