Issue 543413004: High resolution timer fix reland

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 543413004: High resolution timer fix reland (Closed)

Created:
6 years, 3 months ago by cpu_(ooo_6.6-7.5)

Modified:
6 years, 3 months ago

Reviewers:
jamesr, darin (slow to review)

CC:
chromium-reviews, erikwright+watch_chromium.org, sadrul

Base URL:
https://chromium.googlesource.com/chromium/src.git@2125

Project:
chromium

Visibility:
Public.

High resolution timer fix reland (merge to branch) On Windows the message pump code tried to manage the systemwide timer resolution to fire delayed tasks with better than 15ms resolution but it is buggy. This is https://codereview.chromium.org/395913006 please see that review for rationale. BUG=153139 TBR=jamesr,darin TEST=included, also see bug for manual verification. Review URL: https://codereview.chromium.org/509223002 Cr-Commit-Position: refs/heads/master@{#292493} (cherry picked from commit ee89079586f3a1ad727aad4c6aaf3100e220d6e4) Committed: https://chromium.googlesource.com/chromium/src/+/6bed371fb8fe16e4ad8a1aa84f0d412857edf2a6

Created: 6 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+87 lines, -101 lines)			Patch
M	base/message_loop/incoming_task_queue.h	View	2 chunks	+10 lines, -10 lines	0 comments	Download
M	base/message_loop/incoming_task_queue.cc	View	4 chunks	+25 lines, -52 lines	0 comments	Download
M	base/message_loop/message_loop.h	View	3 chunks	+9 lines, -5 lines	0 comments	Download
M	base/message_loop/message_loop.cc	View	7 chunks	+27 lines, -5 lines	0 comments	Download
M	base/message_loop/message_loop_unittest.cc	View	1 chunk	+7 lines, -17 lines	0 comments	Download
M	base/message_loop/message_pump.h	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	base/pending_task.h	View	2 chunks	+3 lines, -3 lines	0 comments	Download
M	base/pending_task.cc	View	2 chunks	+4 lines, -8 lines	0 comments	Download

Total messages: 2 (0 generated)

cpu_(ooo_6.6-7.5)

Committed patchset #1 (id:1) manually as 6bed371.

6 years, 3 months ago (2014-09-16 01:57:53 UTC) #1

Message was sent while issue was closed.

LGTM