Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(73)

Issue 543273002: Change return value from canRunInsecureContentInternal for RemoteFrame (Closed)

Created:
6 years, 3 months ago by nasko
Modified:
6 years, 3 months ago
CC:
blink-reviews, Nate Chapin, gavinp+loader_chromium.org
Project:
blink
Visibility:
Public.

Description

Change return value from canRunInsecureContentInternal for RemoteFrame Do what the comment says, not what the code does :) BUG=399775 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=181537

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M Source/core/loader/MixedContentChecker.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (4 generated)
nasko
Hey guys, Can we have this landed so we can actually navigate out-of-process iframes? Thanks! ...
6 years, 3 months ago (2014-09-05 23:30:17 UTC) #2
nasko
https://codereview.chromium.org/348853009 moved code around and accidentally changed the true to a false. This CL basically ...
6 years, 3 months ago (2014-09-05 23:40:47 UTC) #3
Mike West
LGTM, but please let the chromium bots run before landing. I think there's a test ...
6 years, 3 months ago (2014-09-06 06:56:38 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nasko@chromium.org/543273002/1
6 years, 3 months ago (2014-09-06 11:17:38 UTC) #6
commit-bot: I haz the power
Exceeded time limit waiting for builds to trigger.
6 years, 3 months ago (2014-09-06 13:18:46 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nasko@chromium.org/543273002/1
6 years, 3 months ago (2014-09-08 05:53:00 UTC) #10
commit-bot: I haz the power
6 years, 3 months ago (2014-09-08 05:53:35 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as 181537

Powered by Google App Engine
This is Rietveld 408576698