[Win] Don't show the add/remove desktop shortcut for single users.

chrome/browser/ui/webui/options/manage_profile_handler.cc

Index: chrome/browser/ui/webui/options/manage_profile_handler.cc
diff --git a/chrome/browser/ui/webui/options/manage_profile_handler.cc b/chrome/browser/ui/webui/options/manage_profile_handler.cc
index 41689f80a6da7c7bc0cc5074cfee7277a5f75cda..09b406bc3dac015351b0d83238e5f4af47d1fdc9 100644
--- a/chrome/browser/ui/webui/options/manage_profile_handler.cc
+++ b/chrome/browser/ui/webui/options/manage_profile_handler.cc
@@ -497,6 +497,12 @@ void ManageProfileHandler::OnCreateSupervisedUserPrefChange() {
 
 void ManageProfileHandler::OnHasProfileShortcuts(bool has_shortcuts) {
   DCHECK_CURRENTLY_ON(content::BrowserThread::UI);

[Dan Beam, 2014/09/05 19:19:15]

what happened to the flag check?

[noms (inactive), 2014/09/05 19:50:37]

Maybe I misunderstood your reply, but I thought you said I should always hide
the useless UI. 

Without the flag, with one profile, while you can't press the "Edit" button in
the list to edit the profile (because there is no list), you can still navigate
to chrome://settings/manageProfile, and would see the desktop shortcut button.

On 2014/09/05 19:19:15, Dan Beam wrote:

[Dan Beam, 2014/09/05 22:16:43]

where is the code that hides the useless UI?

[noms (inactive), 2014/09/08 14:30:18]

Initially, in manage_profile_overlay.js, in didShowPage, we have
$('remove-shortcut-button').hidden = true;
$('add-shortcut-button').hidden = true;

Then 'requestHasProfileShortcuts' is called. I've moved this code to that
function, as it was a better place and I missed it the first time around, but
basically when OnHasProfileShortcuts returns, it would call the JS
'receiveHasProfileShortcuts', which changes the visibility of the buttons.

So if we don't ever call receiveHasProfileShortcuts, the buttons stay in their
default state, hidden.
On 2014/09/05 22:16:43, Dan Beam wrote:

+  const ProfileInfoCache& cache =
+      g_browser_process->profile_manager()->GetProfileInfoCache();
+
+  // Don't show the add/remove desktop shortcut button in the single user case.
+  if (cache.GetNumberOfProfiles() <= 1)
+    return;
 
   const base::FundamentalValue has_shortcuts_value(has_shortcuts);
   web_ui()->CallJavascriptFunction(