[Win] Don't show the add/remove desktop shortcut for single users.

chrome/browser/ui/webui/options/manage_profile_handler.cc

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/webui/options/manage_profile_handler.h"
 
 #include "base/bind.h"
 #include "base/bind_helpers.h"
 #include "base/prefs/pref_service.h"
 #include "base/prefs/scoped_user_pref_update.h"
@@ skipping 478 matching lines @@
 
 void ManageProfileHandler::OnCreateSupervisedUserPrefChange() {
   PrefService* prefs = Profile::FromWebUI(web_ui())->GetPrefs();
   base::FundamentalValue allowed(
       prefs->GetBoolean(prefs::kSupervisedUserCreationAllowed));
   web_ui()->CallJavascriptFunction(
       "CreateProfileOverlay.updateSupervisedUsersAllowed", allowed);
 }
 
 void ManageProfileHandler::OnHasProfileShortcuts(bool has_shortcuts) {
   DCHECK_CURRENTLY_ON(content::BrowserThread::UI);

[Dan Beam, 2014/09/05 19:19:15]

what happened to the flag check?

[noms (inactive), 2014/09/05 19:50:37]

Maybe I misunderstood your reply, but I thought you said I should always hide
the useless UI. 

Without the flag, with one profile, while you can't press the "Edit" button in
the list to edit the profile (because there is no list), you can still navigate
to chrome://settings/manageProfile, and would see the desktop shortcut button.

On 2014/09/05 19:19:15, Dan Beam wrote:

[Dan Beam, 2014/09/05 22:16:43]

where is the code that hides the useless UI?

[noms (inactive), 2014/09/08 14:30:18]

Initially, in manage_profile_overlay.js, in didShowPage, we have
$('remove-shortcut-button').hidden = true;
$('add-shortcut-button').hidden = true;

Then 'requestHasProfileShortcuts' is called. I've moved this code to that
function, as it was a better place and I missed it the first time around, but
basically when OnHasProfileShortcuts returns, it would call the JS
'receiveHasProfileShortcuts', which changes the visibility of the buttons.

So if we don't ever call receiveHasProfileShortcuts, the buttons stay in their
default state, hidden.
On 2014/09/05 22:16:43, Dan Beam wrote:

+  const ProfileInfoCache& cache =
+      g_browser_process->profile_manager()->GetProfileInfoCache();
+
+  // Don't show the add/remove desktop shortcut button in the single user case.
+  if (cache.GetNumberOfProfiles() <= 1)
+    return;
 
   const base::FundamentalValue has_shortcuts_value(has_shortcuts);
   web_ui()->CallJavascriptFunction(
       "ManageProfileOverlay.receiveHasProfileShortcuts", has_shortcuts_value);
 }
 
 void ManageProfileHandler::AddProfileShortcut(const base::ListValue* args) {
   base::FilePath profile_file_path;
   if (!GetProfilePathFromArgs(args, &profile_file_path))
     return;
@@ skipping 23 matching lines @@
 
   // Update the UI buttons.
   OnHasProfileShortcuts(false);
 }
 
 void ManageProfileHandler::RefreshGaiaPicture(const base::ListValue* args) {
   profiles::UpdateGaiaProfilePhotoIfNeeded(Profile::FromWebUI(web_ui()));
 }
 
 }  // namespace options