Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(439)

Issue 542833002: Fix themes on retina Mac (Closed)

Created:
6 years, 3 months ago by pkotwicz
Modified:
6 years, 3 months ago
Reviewers:
Elliot Glaysher
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Fix themes on retina Mac Make BrowserThemePack stop assuming that the maximum persistent ID is related to the the size of kPersistingImages. https://codereview.chromium.org/453213002 broke this assumption on Mac. This assumption has been broken on Windows for a long time BUG=405105 TEST=None Committed: https://crrev.com/e5011438e2c769c831b39e9665b95658ca0932eb Cr-Commit-Position: refs/heads/master@{#293406}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -2 lines) Patch
M chrome/browser/themes/browser_theme_pack.cc View 3 chunks +20 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
pkotwicz
Elliot, can you please take a look?
6 years, 3 months ago (2014-09-04 21:13:05 UTC) #2
pkotwicz
I have introduced GetMaxPersistentId() instead of using a constant because I think that this is ...
6 years, 3 months ago (2014-09-04 21:14:45 UTC) #3
Elliot Glaysher
lgtm
6 years, 3 months ago (2014-09-04 21:20:51 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pkotwicz@chromium.org/542833002/1
6 years, 3 months ago (2014-09-04 21:32:13 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1) as f5ffcb5d3ecd197523dfd37fc12a75654615ffd4
6 years, 3 months ago (2014-09-05 02:28:17 UTC) #7
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:35:45 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e5011438e2c769c831b39e9665b95658ca0932eb
Cr-Commit-Position: refs/heads/master@{#293406}

Powered by Google App Engine
This is Rietveld 408576698