Issue 453213002: IDR_THEME_TAB_BACKGROUND_INCOGNITO should not be defined on Mac.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 453213002: IDR_THEME_TAB_BACKGROUND_INCOGNITO should not be defined on Mac. (Closed)

Created:
6 years, 4 months ago by Lei Zhang

Modified:
6 years, 4 months ago

Reviewers:
Elliot Glaysher

CC:
chromium-reviews

Base URL:
svn://chrome-svn/chrome/trunk/src/

Project:
chromium

Visibility:
Public.

IDR_THEME_TAB_BACKGROUND_INCOGNITO should not be defined on Mac. BUG=333201 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=288875

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -1 line)			Patch
	M	chrome/browser/themes/browser_theme_pack.cc	View		1 chunk	+2 lines, -0 lines	0 comments	Download
	M	chrome/browser/themes/browser_theme_pack_unittest.cc	View		2 chunks	+4 lines, -1 line	0 comments	Download

Total messages: 6 (0 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thestig@chromium.org/453213002/1

6 years, 4 months ago (2014-08-11 19:17:33 UTC) #4

commit-bot: I haz the power

FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_chromium_x64_rel on tryserver.chromium.win ...

6 years, 4 months ago (2014-08-11 22:56:05 UTC) #5

Message was sent while issue was closed.

Change committed as 288875