Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Issue 542803002: Disable build/android/buildbot/tests in presubmit (Closed)

Created:
6 years, 3 months ago by cjhopman
Modified:
6 years, 3 months ago
Reviewers:
jbudorick, navabi, zty
CC:
chromium-reviews, erikwright+watch_chromium.org, zty
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Disable build/android/buildbot/tests in presubmit These tests are deleting out/Debug when run. TBR=navabi NOTRY=true BUG=410936 Committed: https://crrev.com/5d7197f599fbe25393ba28339116674eedc2839f Cr-Commit-Position: refs/heads/master@{#293321}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : #

Patch Set 6 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M build/android/PRESUBMIT.py View 1 2 3 4 5 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
cjhopman
jbudorick: ptal
6 years, 3 months ago (2014-09-04 18:44:04 UTC) #2
jbudorick
fine with me, but this is Armand territory
6 years, 3 months ago (2014-09-04 18:46:41 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/cjhopman@chromium.org/542803002/100001
6 years, 3 months ago (2014-09-04 18:50:54 UTC) #6
commit-bot: I haz the power
Committed patchset #6 (id:100001) as 099a3dce96b6132e6e017b9ebb59067c8e0c7906
6 years, 3 months ago (2014-09-04 18:57:28 UTC) #7
commit-bot: I haz the power
Patchset 6 (id:??) landed as https://crrev.com/5d7197f599fbe25393ba28339116674eedc2839f Cr-Commit-Position: refs/heads/master@{#293321}
6 years, 3 months ago (2014-09-10 03:32:11 UTC) #8
navabi
6 years, 3 months ago (2014-09-10 18:43:10 UTC) #10
Message was sent while issue was closed.
lgtm. thanks for putting me on this. We discussed this with zty (added) and
decided since the annotator scripts are on the way out, we don't need these
presubmit tests.

Powered by Google App Engine
This is Rietveld 408576698