Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(83)

Side by Side Diff: build/android/PRESUBMIT.py

Issue 542803002: Disable build/android/buildbot/tests in presubmit (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2013 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2013 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 """Presubmit script for android buildbot. 5 """Presubmit script for android buildbot.
6 6
7 See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts for 7 See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts for
8 details on the presubmit API built into gcl. 8 details on the presubmit API built into gcl.
9 """ 9 """
10 10
(...skipping 30 matching lines...) Expand all
41 black_list=[r'pylib/symbols/.*\.py$', r'gyp/.*\.py$', r'gn/.*\.py'], 41 black_list=[r'pylib/symbols/.*\.py$', r'gyp/.*\.py$', r'gn/.*\.py'],
42 extra_paths_list=[ 42 extra_paths_list=[
43 J(), J('..', '..', 'third_party', 'android_testrunner'), 43 J(), J('..', '..', 'third_party', 'android_testrunner'),
44 J('buildbot')])) 44 J('buildbot')]))
45 output.extend(input_api.canned_checks.RunPylint( 45 output.extend(input_api.canned_checks.RunPylint(
46 input_api, 46 input_api,
47 output_api, 47 output_api,
48 white_list=[r'gyp/.*\.py$', r'gn/.*\.py'], 48 white_list=[r'gyp/.*\.py$', r'gn/.*\.py'],
49 extra_paths_list=[J('gyp'), J('gn')])) 49 extra_paths_list=[J('gyp'), J('gn')]))
50 50
51 output.extend(input_api.canned_checks.RunUnitTestsInDirectory( 51 # Disabled due to http://crbug.com/410936
52 input_api, output_api, J('buildbot', 'tests'))) 52 #output.extend(input_api.canned_checks.RunUnitTestsInDirectory(
53 #input_api, output_api, J('buildbot', 'tests')))
53 54
54 pylib_test_env = dict(input_api.environ) 55 pylib_test_env = dict(input_api.environ)
55 pylib_test_env.update({ 56 pylib_test_env.update({
56 'PYTHONPATH': input_api.PresubmitLocalPath(), 57 'PYTHONPATH': input_api.PresubmitLocalPath(),
57 'PYTHONDONTWRITEBYTECODE': '1', 58 'PYTHONDONTWRITEBYTECODE': '1',
58 }) 59 })
59 output.extend(input_api.canned_checks.RunUnitTests( 60 output.extend(input_api.canned_checks.RunUnitTests(
60 input_api, 61 input_api,
61 output_api, 62 output_api,
62 unit_tests=[ 63 unit_tests=[
63 J('pylib', 'device', 'device_utils_test.py'), 64 J('pylib', 'device', 'device_utils_test.py'),
64 J('pylib', 'gtest', 'test_package_test.py'), 65 J('pylib', 'gtest', 'test_package_test.py'),
65 ], 66 ],
66 env=pylib_test_env)) 67 env=pylib_test_env))
67 output.extend(_CheckDeletionsOnlyFiles(input_api, output_api)) 68 output.extend(_CheckDeletionsOnlyFiles(input_api, output_api))
68 return output 69 return output
69 70
70 71
71 def CheckChangeOnUpload(input_api, output_api): 72 def CheckChangeOnUpload(input_api, output_api):
72 return CommonChecks(input_api, output_api) 73 return CommonChecks(input_api, output_api)
73 74
74 75
75 def CheckChangeOnCommit(input_api, output_api): 76 def CheckChangeOnCommit(input_api, output_api):
76 return CommonChecks(input_api, output_api) 77 return CommonChecks(input_api, output_api)
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698