net/disk_cache/entry_unittest.cc - Issue 542733002: Remove void** from disk_cache interface.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/disk_cache/entry_unittest.cc

Issue 542733002: Remove void** from disk_cache interface. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: narrow given upstream Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: net/disk_cache/entry_unittest.cc

diff --git a/net/disk_cache/entry_unittest.cc b/net/disk_cache/entry_unittest.cc

index 803f98fe00973487d8014b0206ea31b5006eab7a..3757fa5186acf260bcee0d533ade51df026ed3d3 100644

--- a/net/disk_cache/entry_unittest.cc

+++ b/net/disk_cache/entry_unittest.cc

@@ -1617,7 +1617,7 @@ TEST_F(DiskCacheEntryTest, MemoryOnlyEnumerationWithSparseEntries) {

parent_entry->Close();

// Perform the enumerations.

- void* iter = NULL;

+ disk_cache::Backend::Iterator iter;

disk_cache::Entry* entry = NULL;

int count = 0;

while (OpenNextEntry(&iter, &entry) == net::OK) {

@@ -2217,7 +2217,7 @@ TEST_F(DiskCacheEntryTest, CleanupSparseEntry) {

entry->Close();

EXPECT_EQ(4, cache_->GetEntryCount());

- void* iter = NULL;

+ disk_cache::Backend::Iterator iter;

int count = 0;

std::string child_key[2];

while (OpenNextEntry(&iter, &entry) == net::OK) {