net/disk_cache/disk_cache_test_base.cc - Issue 542733002: Remove void** from disk_cache interface.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/disk_cache/disk_cache_test_base.cc

Issue 542733002: Remove void** from disk_cache interface. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: narrow given upstream Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: net/disk_cache/disk_cache_test_base.cc

diff --git a/net/disk_cache/disk_cache_test_base.cc b/net/disk_cache/disk_cache_test_base.cc

index d0f984256ad425113fb440d5b4fb4017b8e9cbe5..17f48c0bdd0838e88f623d3582116d4ab91609e0 100644

--- a/net/disk_cache/disk_cache_test_base.cc

+++ b/net/disk_cache/disk_cache_test_base.cc

@@ -153,7 +153,7 @@ int DiskCacheTestWithCache::DoomEntriesSince(const base::Time initial_time) {

return cb.GetResult(rv);

}

-int DiskCacheTestWithCache::OpenNextEntry(void** iter,

+int DiskCacheTestWithCache::OpenNextEntry(disk_cache::Backend::Iterator* iter,

disk_cache::Entry** next_entry) {

net::TestCompletionCallback cb;

int rv = cache_->OpenNextEntry(iter, next_entry, cb.callback());