Issue 542723004: Make GrDrawState and GrEffectStage use the pending io/exec ref mechanisms.

Issue 542723004: Make GrDrawState and GrEffectStage use the pending io/exec ref mechanisms. (Closed)

Created:
6 years, 3 months ago by bsalomon

Modified:
6 years, 3 months ago

Reviewers:
robertphillips

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia.git@complete

Visibility:
Public.

More Reviews

Description

Make GrDrawState and GrEffectStage use the pending io/exec ref mechanisms. BUG=skia:2889 Committed: https://skia.googlesource.com/skia/+/2a9ca782ba5db5a7ebdc315655d9a30dcd6d9845

Patch Set 2 : revert two files #

Total comments: 2

Patch Set 5 : fix dependent template name error #

Patch Set 6 : rebase again #

Created: 6 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+79 lines, -29 lines)			Patch
M	include/gpu/GrEffectStage.h	View	1 2 3 4 5	2 chunks	+4 lines, -3 lines	0 comments	Download
M	include/gpu/GrProgramElementRef.h	View	1 2 3 4 5	1 chunk	+1 line, -1 line	0 comments	Download
M	include/gpu/GrTextureAccess.h	View		4 chunks	+15 lines, -8 lines	0 comments	Download
M	src/gpu/GrDrawState.h	View	1 2 3 4 5	2 chunks	+5 lines, -3 lines	0 comments	Download
M	src/gpu/GrDrawState.cpp	View	1 2 3 4 5	3 chunks	+6 lines, -3 lines	0 comments	Download
M	src/gpu/GrDrawTarget.h	View	1 2 3 4 5	1 chunk	+4 lines, -0 lines	0 comments	Download
M	src/gpu/GrEffect.cpp	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	src/gpu/GrInOrderDrawBuffer.cpp	View	1 2 3 4 5	1 chunk	+6 lines, -2 lines	0 comments	Download
M	src/gpu/GrRODrawState.h	View	1 2 3 4 5	3 chunks	+19 lines, -4 lines	0 comments	Download
M	src/gpu/GrRODrawState.cpp	View	1 2 3 4 5	2 chunks	+14 lines, -1 line	0 comments	Download
M	src/gpu/GrTextureAccess.cpp	View	1 2 3 4 5	3 chunks	+4 lines, -4 lines	0 comments	Download

Messages

Total messages: 13 (5 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

bsalomon

This is the final CL in the series of moving to the new ref-cnting system.

6 years, 3 months ago (2014-09-04 20:10:37 UTC) #2

robertphillips

lgtm + a unit test request https://codereview.chromium.org/542723004/diff/20001/src/gpu/GrAllocator.h File src/gpu/GrAllocator.h (right): https://codereview.chromium.org/542723004/diff/20001/src/gpu/GrAllocator.h#newcode63 src/gpu/GrAllocator.h:63: /** Add a ...

6 years, 3 months ago (2014-09-04 20:24:35 UTC) #3

bsalomon

https://codereview.chromium.org/542723004/diff/20001/src/gpu/GrAllocator.h File src/gpu/GrAllocator.h (right): https://codereview.chromium.org/542723004/diff/20001/src/gpu/GrAllocator.h#newcode63 src/gpu/GrAllocator.h:63: /** On 2014/09/04 20:24:35, robertphillips wrote: > Add a ...

6 years, 3 months ago (2014-09-05 20:02:55 UTC) #5