Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(112)

Issue 542613002: Fix deoptimization of context. (Closed)

Created:
6 years, 3 months ago by Jarin
Modified:
6 years, 3 months ago
Reviewers:
Michael Starzinger
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

Fix deoptimization of context. We need to handle the case where the context was removed by dead code elimination. In that case, we just use the context from the activation (or from the inlined function if we are inlined). For reference, here is the CL that introduced the bug: https://codereview.chromium.org/522873002 BUG=410556 LOG=N R=mstarzinger@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=23699

Patch Set 1 #

Patch Set 2 : Change tests not to use undefined as context. #

Patch Set 3 : Separate caller context in test #

Patch Set 4 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -6 lines) Patch
M src/deoptimizer.cc View 1 chunk +12 lines, -0 lines 0 comments Download
M test/cctest/compiler/test-codegen-deopt.cc View 1 2 3 3 chunks +12 lines, -6 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Jarin
Could you take a look, please? Unfortunately, the clusterfuzz repro ends up in an infinite ...
6 years, 3 months ago (2014-09-04 12:27:54 UTC) #2
Michael Starzinger
LGTM.
6 years, 3 months ago (2014-09-04 14:51:37 UTC) #3
Jarin
6 years, 3 months ago (2014-09-04 14:53:02 UTC) #4
Message was sent while issue was closed.
Committed patchset #4 (id:60001) manually as 23699 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698