Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(551)

Issue 522873002: Removal of the deoptimization block from Turbofan (Closed)

Created:
6 years, 3 months ago by Jarin
Modified:
6 years, 3 months ago
Reviewers:
Benedikt Meurer
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

Context deoptimization and removal of the deoptimization block in Turbofan This adds context deoptimization to Turbofan and Crankshaft (also submitted separately as https://codereview.chromium.org/515723004/). The second patchset removes the deoptimization/continuation block from calls. BUG= R=bmeurer@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=23547

Patch Set 1 : Add deoptimization of context #

Patch Set 2 : Remove deoptimization block #

Total comments: 4

Patch Set 3 : Remove commented function #

Patch Set 4 : Change constant capitalization #

Unified diffs Side-by-side diffs Delta from patch set Stats (+390 lines, -785 lines) Patch
M src/arm/lithium-arm.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/arm64/lithium-arm64.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/arm/code-generator-arm.cc View 1 2 chunks +7 lines, -9 lines 0 comments Download
M src/compiler/arm/instruction-selector-arm.cc View 1 2 chunks +1 line, -3 lines 0 comments Download
M src/compiler/arm64/code-generator-arm64.cc View 1 2 chunks +7 lines, -8 lines 0 comments Download
M src/compiler/arm64/instruction-selector-arm64.cc View 1 1 chunk +1 line, -2 lines 0 comments Download
M src/compiler/ast-graph-builder.h View 1 2 3 3 chunks +4 lines, -11 lines 0 comments Download
M src/compiler/ast-graph-builder.cc View 1 2 3 9 chunks +14 lines, -40 lines 0 comments Download
M src/compiler/code-generator.h View 1 3 chunks +34 lines, -24 lines 0 comments Download
M src/compiler/code-generator.cc View 1 2 3 7 chunks +65 lines, -59 lines 0 comments Download
M src/compiler/common-operator.h View 1 2 3 3 chunks +26 lines, -10 lines 0 comments Download
M src/compiler/graph-builder.h View 2 chunks +3 lines, -0 lines 0 comments Download
M src/compiler/ia32/code-generator-ia32.cc View 1 2 chunks +7 lines, -8 lines 0 comments Download
M src/compiler/ia32/instruction-selector-ia32.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/instruction.h View 1 2 chunks +23 lines, -7 lines 0 comments Download
M src/compiler/instruction.cc View 1 1 chunk +6 lines, -6 lines 0 comments Download
M src/compiler/instruction-codes.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M src/compiler/instruction-selector.h View 1 1 chunk +1 line, -2 lines 0 comments Download
M src/compiler/instruction-selector.cc View 1 10 chunks +15 lines, -55 lines 0 comments Download
M src/compiler/instruction-selector-impl.h View 1 1 chunk +0 lines, -4 lines 0 comments Download
M src/compiler/js-generic-lowering.cc View 1 1 chunk +0 lines, -3 lines 0 comments Download
M src/compiler/linkage.h View 1 2 chunks +3 lines, -5 lines 0 comments Download
M src/compiler/linkage.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/linkage-impl.h View 1 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/opcodes.h View 1 1 chunk +1 line, -4 lines 0 comments Download
M src/compiler/operator-properties.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M src/compiler/operator-properties-inl.h View 1 2 5 chunks +20 lines, -66 lines 0 comments Download
M src/compiler/raw-machine-assembler.h View 1 1 chunk +3 lines, -5 lines 0 comments Download
M src/compiler/raw-machine-assembler.cc View 1 3 chunks +10 lines, -27 lines 0 comments Download
M src/compiler/schedule.h View 1 3 chunks +5 lines, -30 lines 0 comments Download
M src/compiler/schedule.cc View 1 1 chunk +0 lines, -4 lines 0 comments Download
M src/compiler/scheduler.cc View 1 5 chunks +2 lines, -40 lines 0 comments Download
M src/compiler/verifier.cc View 1 1 chunk +0 lines, -9 lines 0 comments Download
M src/compiler/x64/code-generator-x64.cc View 1 2 chunks +7 lines, -8 lines 0 comments Download
M src/compiler/x64/instruction-selector-x64.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M src/deoptimizer.h View 2 chunks +4 lines, -0 lines 0 comments Download
M src/deoptimizer.cc View 4 chunks +9 lines, -7 lines 0 comments Download
M src/hydrogen.cc View 1 2 3 1 chunk +2 lines, -3 lines 0 comments Download
M src/hydrogen-instructions.h View 4 chunks +15 lines, -19 lines 0 comments Download
M src/ia32/lithium-ia32.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M src/lithium.cc View 2 chunks +14 lines, -8 lines 0 comments Download
M src/mips/lithium-mips.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/mips64/lithium-mips64.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/runtime.cc View 1 2 3 3 chunks +5 lines, -2 lines 0 comments Download
M src/x64/lithium-x64.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M src/x87/lithium-x87.cc View 1 chunk +1 line, -0 lines 0 comments Download
M test/cctest/compiler/test-codegen-deopt.cc View 1 2 3 5 chunks +13 lines, -47 lines 0 comments Download
M test/cctest/compiler/test-schedule.cc View 1 1 chunk +0 lines, -14 lines 0 comments Download
M test/cctest/compiler/test-scheduler.cc View 1 1 chunk +0 lines, -136 lines 0 comments Download
M test/compiler-unittests/instruction-selector-unittest.h View 1 1 chunk +3 lines, -3 lines 0 comments Download
M test/compiler-unittests/instruction-selector-unittest.cc View 1 2 3 8 chunks +30 lines, -70 lines 0 comments Download
M test/mjsunit/debug-clearbreakpointgroup.js View 1 chunk +1 line, -0 lines 0 comments Download
M test/mjsunit/debug-evaluate-closure.js View 1 chunk +1 line, -0 lines 0 comments Download
M test/mjsunit/debug-evaluate-with.js View 1 chunk +2 lines, -0 lines 0 comments Download
M test/mjsunit/debug-step-2.js View 1 chunk +1 line, -0 lines 0 comments Download
M test/mjsunit/mjsunit.status View 2 chunks +0 lines, -15 lines 0 comments Download
M test/mjsunit/regress/regress-1170187.js View 1 chunk +2 lines, -0 lines 0 comments Download
M test/mjsunit/regress/regress-119609.js View 1 chunk +1 line, -0 lines 0 comments Download
M test/mjsunit/regress/regress-131994.js View 1 chunk +1 line, -0 lines 0 comments Download
M test/mjsunit/regress/regress-325676.js View 1 chunk +1 line, -0 lines 0 comments Download
M test/mjsunit/regress/regress-crbug-107996.js View 1 chunk +1 line, -0 lines 0 comments Download
M test/mjsunit/regress/regress-crbug-171715.js View 1 chunk +1 line, -0 lines 0 comments Download
M test/mjsunit/regress/regress-crbug-222893.js View 1 chunk +1 line, -0 lines 0 comments Download
M test/mjsunit/regress/regress-debug-deopt-while-recompile.js View 1 chunk +1 line, -0 lines 0 comments Download
M test/mjsunit/regress/regress-opt-after-debug-deopt.js View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
Jarin
Could you take a look, please?
6 years, 3 months ago (2014-08-29 18:45:00 UTC) #2
Benedikt Meurer
https://codereview.chromium.org/522873002/diff/20001/src/compiler/common-operator.h File src/compiler/common-operator.h (right): https://codereview.chromium.org/522873002/diff/20001/src/compiler/common-operator.h#newcode50 src/compiler/common-operator.h:50: PUSH_OUTPUT, // Push the output on the expression stack. ...
6 years, 3 months ago (2014-09-01 09:07:05 UTC) #3
Jarin
https://codereview.chromium.org/522873002/diff/20001/src/compiler/common-operator.h File src/compiler/common-operator.h (right): https://codereview.chromium.org/522873002/diff/20001/src/compiler/common-operator.h#newcode50 src/compiler/common-operator.h:50: PUSH_OUTPUT, // Push the output on the expression stack. ...
6 years, 3 months ago (2014-09-01 09:23:34 UTC) #4
Benedikt Meurer
lgtm
6 years, 3 months ago (2014-09-01 09:23:46 UTC) #5
Jarin
6 years, 3 months ago (2014-09-01 09:32:00 UTC) #6
Message was sent while issue was closed.
Committed patchset #4 manually as 23547 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698