Issue 542603003: Revert "Keep a copy of page id in RenderViewHost."

Issue 542603003: Revert "Keep a copy of page id in RenderViewHost." (Closed)

Created:
6 years, 3 months ago by Avi (use Gerrit)

Modified:
6 years, 3 months ago

Reviewers:

CC:
chromium-reviews, darin-cc_chromium.org, nasko+codewatch_chromium.org, jam, creis+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Project:
chromium

Visibility:
Public.

Revert "Keep a copy of page id in RenderViewHost." This reverts commit 45db74f875d668805afad8e73b7840e9df9c3215. We have the crash logs we need from the canary. BUG=407376 TBR=creis@chromium.org,rsesek@chromium.org Committed: https://crrev.com/f50321a4b0af8e89553a589d0dfba7e8f3573734 Cr-Commit-Position: refs/heads/master@{#293420}

Created: 6 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+11 lines, -82 lines)			Patch
M	chrome/common/crash_keys.cc	View	1 chunk	+0 lines, -7 lines	0 comments	Download
M	content/browser/frame_host/navigation_controller_impl_unittest.cc	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	content/browser/frame_host/render_frame_host_impl.cc	View	5 chunks	+2 lines, -32 lines	0 comments	Download
M	content/browser/renderer_host/render_view_host_impl.h	View	1 chunk	+0 lines, -5 lines	0 comments	Download
M	content/browser/renderer_host/render_view_host_impl.cc	View	4 chunks	+2 lines, -18 lines	0 comments	Download
M	content/browser/renderer_host/render_view_host_unittest.cc	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	content/renderer/render_frame_impl.cc	View	5 chunks	+0 lines, -5 lines	0 comments	Download
M	content/renderer/render_view_impl.h	View	1 chunk	+0 lines, -5 lines	0 comments	Download
M	content/renderer/render_view_impl.cc	View	3 chunks	+0 lines, -3 lines	0 comments	Download
M	content/test/test_render_view_host.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	content/test/test_render_view_host.cc	View	1 chunk	+2 lines, -2 lines	0 comments	Download

Total messages: 4 (1 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/avi@chromium.org/542603003/1

6 years, 3 months ago (2014-09-04 23:06:06 UTC) #2

commit-bot: I haz the power

Committed patchset #1 (id:1) as 1a94dffbe560381b59a34f297c36f026c8e40794

6 years, 3 months ago (2014-09-05 03:29:55 UTC) #3

commit-bot: I haz the power

6 years, 3 months ago (2014-09-10 03:36:14 UTC) #4

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/f50321a4b0af8e89553a589d0dfba7e8f3573734
Cr-Commit-Position: refs/heads/master@{#293420}