Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1707)

Unified Diff: content/renderer/render_view_impl.cc

Issue 542603003: Revert "Keep a copy of page id in RenderViewHost." (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/renderer/render_view_impl.h ('k') | content/test/test_render_view_host.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/renderer/render_view_impl.cc
diff --git a/content/renderer/render_view_impl.cc b/content/renderer/render_view_impl.cc
index a6b4bc45d5482397d36031a44cd0dfc62d1a6e21..a7df08bed46f4974db0d7019cfaf1a1bc0385371 100644
--- a/content/renderer/render_view_impl.cc
+++ b/content/renderer/render_view_impl.cc
@@ -666,7 +666,6 @@ RenderViewImpl::RenderViewImpl(RenderViewImplParams* params)
opener_suppressed_(false),
suppress_dialogs_until_swap_out_(false),
page_id_(-1),
- page_id_not_yet_reported_(false),
last_page_id_sent_to_browser_(-1),
next_page_id_(params->next_page_id),
history_list_offset_(-1),
@@ -1550,7 +1549,6 @@ void RenderViewImpl::SendUpdateState(HistoryEntry* entry) {
if (entry->root().urlString() == WebString::fromUTF8(kSwappedOutURL))
return;
- CHECK(!page_id_not_yet_reported_);
Send(new ViewHostMsg_UpdateState(
routing_id_, page_id_, HistoryEntryToPageState(entry)));
}
@@ -1869,7 +1867,6 @@ void RenderViewImpl::UpdateTargetURL(const GURL& url,
// see |ParamTraits<GURL>|.
if (latest_url.possibly_invalid_spec().size() > GetMaxURLChars())
latest_url = GURL();
- CHECK(!page_id_not_yet_reported_);
Send(new ViewHostMsg_UpdateTargetURL(routing_id_, page_id_, latest_url));
target_url_ = latest_url;
target_url_status_ = TARGET_INFLIGHT;
« no previous file with comments | « content/renderer/render_view_impl.h ('k') | content/test/test_render_view_host.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698