Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
542533002:
[Aura] Fix window resize handling on fullscreen event (Closed)
|
Created:
6 years, 3 months ago by tzik Modified:
6 years, 3 months ago Reviewers:
Elliot Glaysher CC:
chromium-reviews, tfarina, ben+views_chromium.org, tdanderson+views_chromium.org Base URL:
https://chromium.googlesource.com/chromium/src.git@master Project:
chromium Visibility:
Public. |
Description[Aura] Fix window resize handling on fullscreen event
Skip resize handling on fullscreen event.
BUG=408409
R=erg@chromium.org
Committed: https://crrev.com/54b0eaa07003f201365552e8740d6365ad27a198
Cr-Commit-Position: refs/heads/master@{#293615}
Patch Set 1 #Patch Set 2 : cancel resize event on fullscreen event #
Total comments: 2
Patch Set 3 : #Messages
Total messages: 20 (7 generated)
PTL
https://codereview.chromium.org/542533002/diff/20001/ui/views/widget/desktop_... File ui/views/widget/desktop_aura/desktop_window_tree_host_x11.cc (right): https://codereview.chromium.org/542533002/diff/20001/ui/views/widget/desktop_... ui/views/widget/desktop_aura/desktop_window_tree_host_x11.cc:1726: close_widget_factory_.GetWeakPtr())); I suspect that you should be writing this a different way. Trying to pass state through a member variable is ugly. If your intention is to cancel the previous resize, you should probably just cancel it before you send your new DelayedResize() event.
https://codereview.chromium.org/542533002/diff/20001/ui/views/widget/desktop_... File ui/views/widget/desktop_aura/desktop_window_tree_host_x11.cc (right): https://codereview.chromium.org/542533002/diff/20001/ui/views/widget/desktop_... ui/views/widget/desktop_aura/desktop_window_tree_host_x11.cc:1726: close_widget_factory_.GetWeakPtr())); On 2014/09/04 17:19:19, Elliot Glaysher wrote: > I suspect that you should be writing this a different way. Trying to pass state > through a member variable is ugly. If your intention is to cancel the previous > resize, you should probably just cancel it before you send your new > DelayedResize() event. Hm, right. I misunderstood something.. The previous code already uses the latest value and resets previous event. Reverted this part.
lgtm
The CQ bit was checked by tzik@chromium.org
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tzik@chromium.org/542533002/40001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: android_clang_dbg_recipe on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_clang_d...)
The CQ bit was checked by tzik@chromium.org
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tzik@chromium.org/542533002/40001
The CQ bit was unchecked by commit-bot@chromium.org
Exceeded time limit waiting for builds to trigger.
The CQ bit was checked by tzik@chromium.org
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tzik@chromium.org/542533002/40001
The CQ bit was unchecked by commit-bot@chromium.org
Exceeded time limit waiting for builds to trigger.
The CQ bit was checked by tzik@chromium.org
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tzik@chromium.org/542533002/40001
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as 792df8aefc7066445e23b03c8f25fc755531916d
Message was sent while issue was closed.
Patchset 3 (id:??) landed as https://crrev.com/54b0eaa07003f201365552e8740d6365ad27a198 Cr-Commit-Position: refs/heads/master@{#293615} |
