[Aura] Fix window resize handling on fullscreen event

ui/views/widget/desktop_aura/desktop_window_tree_host_x11.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ui/views/widget/desktop_aura/desktop_window_tree_host_x11.h"
 
 #include <X11/extensions/shape.h>
 #include <X11/extensions/XInput2.h>
 #include <X11/Xatom.h>
 #include <X11/Xregion.h>
@@ skipping 687 matching lines @@
   // Replace the frame and layout the contents. Even though we don't have a
   // swapable glass frame like on Windows, we still replace the frame because
   // the button assets don't update otherwise.
   native_widget_delegate_->AsWidget()->non_client_view()->UpdateFrame();
 }
 
 void DesktopWindowTreeHostX11::SetFullscreen(bool fullscreen) {
   if (is_fullscreen_ == fullscreen)
     return;
   is_fullscreen_ = fullscreen;
+  if (is_fullscreen_)
+    delayed_resize_task_.Cancel();
 
   // Work around a bug where if we try to unfullscreen, metacity immediately
   // fullscreens us again. This is a little flickery and not necessary if
   // there's a gnome-panel, but it's not easy to detect whether there's a
   // panel or not.
   bool unmaximize_and_remaximize = !fullscreen && IsMaximized() &&
                                    ui::GuessWindowManager() == ui::WM_METACITY;
 
   if (unmaximize_and_remaximize)
     Restore();
@@ skipping 993 matching lines @@
                        xev->xconfigure.width, xev->xconfigure.height);
       bool size_changed = bounds_.size() != bounds.size();
       bool origin_changed = bounds_.origin() != bounds.origin();
       previous_bounds_ = bounds_;
       bounds_ = bounds;
 
       if (origin_changed)
         OnHostMoved(bounds_.origin());
 
       if (size_changed) {
+        window_size_ = bounds.size();
         delayed_resize_task_.Reset(base::Bind(
             &DesktopWindowTreeHostX11::DelayedResize,
-            close_widget_factory_.GetWeakPtr(),
-            bounds.size()));
+            close_widget_factory_.GetWeakPtr()));

[Elliot Glaysher, 2014/09/04 17:19:19]

I suspect that you should be writing this a different way. Trying to pass state
through a member variable is ugly. If your intention is to cancel the previous
resize, you should probably just cancel it before you send your new
DelayedResize() event.

[tzik, 2014/09/05 04:12:23]

Hm, right. I misunderstood something..
The previous code already uses the latest value and resets previous event.
Reverted this part.

         base::MessageLoop::current()->PostTask(
             FROM_HERE, delayed_resize_task_.callback());
       }
       break;
     }
     case GenericEvent: {
       ui::TouchFactory* factory = ui::TouchFactory::GetInstance();
       if (!factory->ShouldProcessXI2Event(xev))
         break;
 
@@ skipping 149 matching lines @@
       break;
     }
     case SelectionNotify: {
       drag_drop_client_->OnSelectionNotify(xev->xselection);
       break;
     }
   }
   return ui::POST_DISPATCH_STOP_PROPAGATION;
 }
 
-void DesktopWindowTreeHostX11::DelayedResize(const gfx::Size& size) {
-  OnHostResized(size);
+void DesktopWindowTreeHostX11::DelayedResize() {
+  OnHostResized(window_size_);
   ResetWindowRegion();
   delayed_resize_task_.Cancel();
 }
 
 ////////////////////////////////////////////////////////////////////////////////
 // DesktopWindowTreeHost, public:
 
 // static
 DesktopWindowTreeHost* DesktopWindowTreeHost::Create(
     internal::NativeWidgetDelegate* native_widget_delegate,
     DesktopNativeWidgetAura* desktop_native_widget_aura) {
   return new DesktopWindowTreeHostX11(native_widget_delegate,
                                       desktop_native_widget_aura);
 }
 
 // static
 ui::NativeTheme* DesktopWindowTreeHost::GetNativeTheme(aura::Window* window) {
   const views::LinuxUI* linux_ui = views::LinuxUI::instance();
   if (linux_ui) {
     ui::NativeTheme* native_theme = linux_ui->GetNativeTheme(window);
     if (native_theme)
       return native_theme;
   }
 
   return ui::NativeTheme::instance();
 }
 
 }  // namespace views