runtime/bin/vmservice/observatory/test/contexts_test.dart - Issue 542363003: Don't double-escape in strings in the VM Service, and don't use \u0000 to determine the string lengt

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/bin/vmservice/observatory/test/contexts_test.dart

Issue 542363003: Don't double-escape in strings in the VM Service, and don't use \u0000 to determine the string lengt (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: build Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « runtime/bin/vmservice/observatory/lib/src/service/object.dart ('k') | runtime/bin/vmservice/observatory/test/string_escaping_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: runtime/bin/vmservice/observatory/test/contexts_test.dart

diff --git a/runtime/bin/vmservice/observatory/test/contexts_test.dart b/runtime/bin/vmservice/observatory/test/contexts_test.dart

index 38a5a2e2a472153760f3cd03e112e4e76680f120..05ae127e8fe6c825e593e3265cf39ab6d368e2bc 100644

--- a/runtime/bin/vmservice/observatory/test/contexts_test.dart

+++ b/runtime/bin/vmservice/observatory/test/contexts_test.dart

@@ -72,7 +72,7 @@ var tests = [

expect(block.closureCtxt.length, equals(1));

return block.closureCtxt.load().then((Context ctxt) {

expect(ctxt.variables.single['value'].isString, isTrue);

- expect(ctxt.variables.single['value'].valueAsString, equals('"I could be copied into the block"'));

+ expect(ctxt.variables.single['value'].valueAsString, equals('I could be copied into the block'));

expect(block.closureCtxt.parentContext.isNull, isTrue);

});