runtime/bin/vmservice/observatory/lib/src/service/object.dart - Issue 542363003: Don't double-escape in strings in the VM Service, and don't use \u0000 to determine the string lengt

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/bin/vmservice/observatory/lib/src/service/object.dart

Issue 542363003: Don't double-escape in strings in the VM Service, and don't use \u0000 to determine the string lengt (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: build Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « runtime/bin/vmservice/observatory/lib/src/elements/observatory_element.dart ('k') | runtime/bin/vmservice/observatory/test/contexts_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: runtime/bin/vmservice/observatory/lib/src/service/object.dart

diff --git a/runtime/bin/vmservice/observatory/lib/src/service/object.dart b/runtime/bin/vmservice/observatory/lib/src/service/object.dart

index 7d5ab83f51562efb2109a46bb8e6fa85616709fd..13198724d3db7843e818d54ee969984f1a628b20 100644

--- a/runtime/bin/vmservice/observatory/lib/src/service/object.dart

+++ b/runtime/bin/vmservice/observatory/lib/src/service/object.dart

@@ -1226,7 +1226,7 @@ class DartError extends ServiceObject {

@observable String kind;

@observable String message;

@observable Instance exception;

- @observable ServiceMap stacktrace;

+ @observable Instance stacktrace;

void _update(ObservableMap map, bool mapIsRef) {

kind = map['kind'];

@@ -1509,6 +1509,7 @@ class Instance extends ServiceObject {

@observable Class clazz;

@observable int size;

@observable String valueAsString; // If primitive.

+ @observable bool valueAsStringIsTruncated;

@observable ServiceFunction closureFunc; // If a closure.

@observable Context closureCtxt; // If a closure.

@observable String name; // If a Type.

@@ -1534,6 +1535,8 @@ class Instance extends ServiceObject {

clazz = map['class'];

size = map['size'];

valueAsString = map['valueAsString'];

+ // Coerce absence to false.

+ valueAsStringIsTruncated = map['valueAsStringIsTruncated'] == true;

closureFunc = map['closureFunc'];

closureCtxt = map['closureCtxt'];

name = map['name'];