Make net::DataURL's MIME string check stricter

webkit/child/weburlloader_impl.cc

Index: webkit/child/weburlloader_impl.cc
diff --git a/webkit/child/weburlloader_impl.cc b/webkit/child/weburlloader_impl.cc
index 09273f8881b2fe825a330bfc50fbf72138860e49..2ba4c92665ab3ab0f9504781563816ab1f38ebf7 100644
--- a/webkit/child/weburlloader_impl.cc
+++ b/webkit/child/weburlloader_impl.cc
@@ -132,7 +132,17 @@ bool GetInfoFromDataURL(const GURL& url,
     info->load_timing.request_start_time = now;
     info->request_time = now;
     info->response_time = now;
-    info->headers = NULL;
+
+    std::string raw_header = "HTTP/1.1 200 OK";

[sof, 2013/10/31 08:19:32]

Possible to bring in the use of net::HttpUtil::AssembleRawHeaders() here?

[tyoshino (SeeGerritForStatus), 2013/10/31 08:53:20]

Thanks for suggestion. But it'll be:

    std::string raw_header = "HTTP/1.1 200 OK\r\nContent-Type: " + mime_type;
    if (!charset.empty()) {
      raw_header += ";charset=";
      raw_header += charset;
    }
    raw_header += "\r\n\r\n";

    info->headers = new net::HttpResponseHeaders(
        net::HttpUtil::AssembleRawHeaders(
            raw_header.data(), raw_header.size()));

Not so simpler than current. WDYT?

[sof, 2013/10/31 15:26:59]

Yes, that wouldn't avoid the explicit formatting of
the response after all. An alternative is to create an empty
response and use AddHeader().

+    raw_header += '\0';
+    raw_header += "Content-Type: " + mime_type;
+    if (!charset.empty()) {
+      raw_header += ";charset=";
+      raw_header += charset;
+    }
+    raw_header.append("\0\0", 2);
+
+    info->headers = new net::HttpResponseHeaders(raw_header);
     info->mime_type.swap(mime_type);
     info->charset.swap(charset);
     info->security_info.clear();