Make net::DataURL's MIME string check stricter

webkit/child/weburlloader_impl.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // An implementation of WebURLLoader in terms of ResourceLoaderBridge.
 
 #include "webkit/child/weburlloader_impl.h"
 
 #include "base/bind.h"
 #include "base/files/file_path.h"
@@ skipping 114 matching lines @@
   std::string mime_type;
   std::string charset;
   if (net::DataURL::Parse(url, &mime_type, &charset, data)) {
     *error_code = net::OK;
     // Assure same time for all time fields of data: URLs.
     Time now = Time::Now();
     info->load_timing.request_start = TimeTicks::Now();
     info->load_timing.request_start_time = now;
     info->request_time = now;
     info->response_time = now;
-    info->headers = NULL;
+
+    std::string raw_header = "HTTP/1.1 200 OK";

[sof, 2013/10/31 08:19:32]

Possible to bring in the use of net::HttpUtil::AssembleRawHeaders() here?

[tyoshino (SeeGerritForStatus), 2013/10/31 08:53:20]

Thanks for suggestion. But it'll be:

    std::string raw_header = "HTTP/1.1 200 OK\r\nContent-Type: " + mime_type;
    if (!charset.empty()) {
      raw_header += ";charset=";
      raw_header += charset;
    }
    raw_header += "\r\n\r\n";

    info->headers = new net::HttpResponseHeaders(
        net::HttpUtil::AssembleRawHeaders(
            raw_header.data(), raw_header.size()));

Not so simpler than current. WDYT?

[sof, 2013/10/31 15:26:59]

Yes, that wouldn't avoid the explicit formatting of
the response after all. An alternative is to create an empty
response and use AddHeader().

+    raw_header += '\0';
+    raw_header += "Content-Type: " + mime_type;
+    if (!charset.empty()) {
+      raw_header += ";charset=";
+      raw_header += charset;
+    }
+    raw_header.append("\0\0", 2);
+
+    info->headers = new net::HttpResponseHeaders(raw_header);
     info->mime_type.swap(mime_type);
     info->charset.swap(charset);
     info->security_info.clear();
     info->content_length = data->length();
     info->encoded_data_length = 0;
 
     return true;
   }
 
   *error_code = net::ERR_INVALID_URL;
@@ skipping 699 matching lines @@
 
 void WebURLLoaderImpl::setDefersLoading(bool value) {
   context_->SetDefersLoading(value);
 }
 
 void WebURLLoaderImpl::didChangePriority(WebURLRequest::Priority new_priority) {
   context_->DidChangePriority(new_priority);
 }
 
 }  // namespace webkit_glue