Convert ui::GestureEvent coordinates during targeting

Convert ui::GestureEvent coordinates during targeting

In RootView::DispatchGestureEvent(), use Event::Clone() 
to copy gesture events prior to processing and perform 
coordinate conversion of the events during targeting but 
before dispatch (so the location of the gesture event 
is in the coordinate space of the target).

In preparation for removing 
RootView::DispatchGestureEvent(), also make the
corresponding changes to 
EventProcessor::OnEventFromSource(). These changes
are necessary to ensure that located events will
be dispatched with their locations in the correct
coordinate space in all situations (in particular,
when an event is bubbling during an invocation of 
nested event-processing).

BUG=411487
TEST=WidgetTest.GestureEventLocationWhileBubbling,
     ViewTargeterTest.GestureEventCoordinateConversion,
     modified ViewTargeterTest.ViewTargeterForGestureEvents

Committed: https://crrev.com/76b7f06e911e996f7a07e090c7ec4057a62b8314
Cr-Commit-Position: refs/heads/master@{#293797}

[tdanderson, 2014-09-05 22:18:17]

tdanderson@chromium.org changed reviewers:
+ sadrul@chromium.org

[tdanderson, 2014-09-05 22:18:18]

Sadrul, can you please let me know what you think?

[tdanderson, 2014-09-05 23:33:36]

On 2014/09/05 22:18:18, tdanderson wrote:
> Sadrul, can you please let me know what you think?

Please hold off on looking at this for now. As discussed over
IM, it looks like coordinate conversion should happen in
ViewTargeter instead (which we're not actually doing currently).
I'll upload a new patch set in the near future and re-ping you.

[tdanderson, 2014-09-05 23:33:46]

tdanderson@chromium.org changed reviewers:
- sadrul@chromium.org

[tdanderson, 2014-09-07 00:50:30]

tdanderson@chromium.org changed reviewers:
+ sadrul@chromium.org

[tdanderson, 2014-09-07 00:50:31]

Sadrul, can you please take a look?

[sadrul, 2014-09-07 05:33:47]

LGTM

https://codereview.chromium.org/542323002/diff/20001/ui/events/event_processo...
File ui/events/event_processor.cc (right):

https://codereview.chromium.org/542323002/diff/20001/ui/events/event_processo...
ui/events/event_processor.cc:29: EventTarget* target =
targeter->FindTargetForEvent(root, event_to_dispatch);
Can you update the test in event_processor_unittest.cc to check that the
location of the original event does not change (in
ReDispatchEventHandler::OnMouseEvent()) in this scenario?

https://codereview.chromium.org/542323002/diff/20001/ui/views/widget/widget_u...
File ui/views/widget/widget_unittest.cc (right):

https://codereview.chromium.org/542323002/diff/20001/ui/views/widget/widget_u...
ui/views/widget/widget_unittest.cc:47: gfx::Point ConvertPointToView(View* view,
const gfx::Point& p) {
FromWidgetToView?

[tdanderson, 2014-09-08 17:21:08]

https://codereview.chromium.org/542323002/diff/20001/ui/events/event_processo...
File ui/events/event_processor.cc (right):

https://codereview.chromium.org/542323002/diff/20001/ui/events/event_processo...
ui/events/event_processor.cc:29: EventTarget* target =
targeter->FindTargetForEvent(root, event_to_dispatch);
On 2014/09/07 05:33:47, sadrul wrote:
> Can you update the test in event_processor_unittest.cc to check that the
> location of the original event does not change (in
> ReDispatchEventHandler::OnMouseEvent()) in this scenario?

Done.

https://codereview.chromium.org/542323002/diff/20001/ui/views/widget/widget_u...
File ui/views/widget/widget_unittest.cc (right):

https://codereview.chromium.org/542323002/diff/20001/ui/views/widget/widget_u...
ui/views/widget/widget_unittest.cc:47: gfx::Point ConvertPointToView(View* view,
const gfx::Point& p) {
On 2014/09/07 05:33:47, sadrul wrote:
> FromWidgetToView?

Done.

[tdanderson, 2014-09-08 17:21:12]

The CQ bit was checked by tdanderson@chromium.org

[tdanderson, 2014-09-08 17:27:51]

The CQ bit was unchecked by tdanderson@chromium.org

[tdanderson, 2014-09-08 17:27:56]

The CQ bit was checked by tdanderson@chromium.org

[commit-bot: I haz the power, 2014-09-08 17:39:38]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/tdanderson@chromium.org/542323002/40001

[tdanderson, 2014-09-08 17:47:14]

The CQ bit was unchecked by tdanderson@chromium.org

[tdanderson, 2014-09-08 17:47:16]

The CQ bit was checked by tdanderson@chromium.org

[commit-bot: I haz the power, 2014-09-08 17:48:36]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/tdanderson@chromium.org/542323002/40001

[tdanderson, 2014-09-08 18:29:25]

The CQ bit was unchecked by tdanderson@chromium.org

[tdanderson, 2014-09-08 18:29:27]

The CQ bit was checked by tdanderson@chromium.org

[commit-bot: I haz the power, 2014-09-08 18:48:38]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/tdanderson@chromium.org/542323002/40001

[commit-bot: I haz the power, 2014-09-08 22:31:02]

Committed patchset #3 (id:40001) as 4872e34aada033b47f5ca504a63003b0eb793dac

[commit-bot: I haz the power, 2014-09-10 03:48:31]

Patchset 3 (id:??) landed as
https://crrev.com/76b7f06e911e996f7a07e090c7ec4057a62b8314
Cr-Commit-Position: refs/heads/master@{#293797}