Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(247)

Issue 54223003: drive: Recover cache entries from trashed DB to filter out non-dirty cache files (Closed)

Created:
7 years, 1 month ago by hashimoto
Modified:
7 years, 1 month ago
Reviewers:
kinaba
CC:
chromium-reviews, nkostylev+watch_chromium.org, hashimoto+watch_chromium.org, tfarina, oshima+watch_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org
Visibility:
Public.

Description

drive: Recover cache entries from trashed DB to filter out non-dirty cache files After non-dirty cache files being filtered out during cache file recovery, the destination directory should contain users' necessary files only. Move the preserved DB to 'trashed' path, instead of deleting it. Add ResourceMetadataStorage::RecoverCacheEntriesFromTrashedResourceMap to collect cache entries from the trashed DB. Pass the collected cache entries to FileCache::RecoverFilesFromCacheDirectory. BUG=277333 TEST=unit_tests R=kinaba@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=232289

Patch Set 1 : #

Patch Set 2 : #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+152 lines, -9 lines) Patch
M chrome/browser/chromeos/drive/drive_integration_service.cc View 1 chunk +6 lines, -1 line 0 comments Download
M chrome/browser/chromeos/drive/file_cache.h View 1 chunk +5 lines, -1 line 0 comments Download
M chrome/browser/chromeos/drive/file_cache.cc View 1 2 chunks +18 lines, -1 line 0 comments Download
M chrome/browser/chromeos/drive/file_cache_unittest.cc View 1 chunk +7 lines, -1 line 0 comments Download
M chrome/browser/chromeos/drive/resource_metadata_storage.h View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/drive/resource_metadata_storage.cc View 1 2 6 chunks +75 lines, -5 lines 0 comments Download
M chrome/browser/chromeos/drive/resource_metadata_storage_unittest.cc View 1 chunk +37 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
hashimoto
7 years, 1 month ago (2013-10-31 09:02:29 UTC) #1
kinaba
lgtm
7 years, 1 month ago (2013-10-31 09:22:15 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hashimoto@chromium.org/54223003/120001
7 years, 1 month ago (2013-10-31 11:20:22 UTC) #3
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=216556
7 years, 1 month ago (2013-10-31 16:39:41 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hashimoto@chromium.org/54223003/120001
7 years, 1 month ago (2013-11-01 02:52:24 UTC) #5
hashimoto
7 years, 1 month ago (2013-11-01 05:13:15 UTC) #6
Message was sent while issue was closed.
Committed patchset #3 manually as r232289 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698