Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(68)

Issue 542153004: Make the device::HidService destructor protected. (Closed)

Created:
6 years, 3 months ago by Reilly Grant (use Gerrit)
Modified:
6 years, 3 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Make the device::HidService destructor protected. This prevents anything other than device::HidService::Destroyer from calling the destructor. For example, scoped_ptr, as was the case in HidConnectionTest. BUG= Committed: https://crrev.com/ce69e2adaf3ec91056ec87e1a59848b9781709c1 Cr-Commit-Position: refs/heads/master@{#293623}

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -11 lines) Patch
M device/hid/hid_connection_unittest.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M device/hid/hid_service.h View 3 chunks +3 lines, -2 lines 2 comments Download
M device/hid/hid_service.cc View 3 chunks +6 lines, -6 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
Reilly Grant (use Gerrit)
6 years, 3 months ago (2014-09-05 19:50:02 UTC) #2
Ken Rockot(use gerrit already)
lgtm https://codereview.chromium.org/542153004/diff/1/device/hid/hid_service.h File device/hid/hid_service.h (right): https://codereview.chromium.org/542153004/diff/1/device/hid/hid_service.h#newcode42 device/hid/hid_service.h:42: virtual ~HidService(); Any reason not to make it ...
6 years, 3 months ago (2014-09-05 19:52:04 UTC) #3
Reilly Grant (use Gerrit)
https://codereview.chromium.org/542153004/diff/1/device/hid/hid_service.h File device/hid/hid_service.h (right): https://codereview.chromium.org/542153004/diff/1/device/hid/hid_service.h#newcode42 device/hid/hid_service.h:42: virtual ~HidService(); On 2014/09/05 19:52:04, Ken Rockot wrote: > ...
6 years, 3 months ago (2014-09-05 20:19:05 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/reillyg@chromium.org/542153004/1
6 years, 3 months ago (2014-09-05 20:47:09 UTC) #6
commit-bot: I haz the power
Exceeded time limit waiting for builds to trigger.
6 years, 3 months ago (2014-09-06 07:52:38 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/reillyg@chromium.org/542153004/1
6 years, 3 months ago (2014-09-06 17:05:23 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1) as 3cff8f4f41ac652cabd5a571230da0c3307494be
6 years, 3 months ago (2014-09-06 18:40:50 UTC) #11
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:42:54 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ce69e2adaf3ec91056ec87e1a59848b9781709c1
Cr-Commit-Position: refs/heads/master@{#293623}

Powered by Google App Engine
This is Rietveld 408576698