Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(935)

Side by Side Diff: device/hid/hid_service.cc

Issue 542153004: Make the device::HidService destructor protected. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« device/hid/hid_service.h ('K') | « device/hid/hid_service.h ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "device/hid/hid_service.h" 5 #include "device/hid/hid_service.h"
6 6
7 #include "base/lazy_instance.h" 7 #include "base/lazy_instance.h"
8 #include "base/logging.h" 8 #include "base/logging.h"
9 #include "base/memory/scoped_vector.h" 9 #include "base/memory/scoped_vector.h"
10 #include "base/message_loop/message_loop.h" 10 #include "base/message_loop/message_loop.h"
11 #include "base/stl_util.h" 11 #include "base/stl_util.h"
12 #include "base/threading/thread_restrictions.h" 12 #include "base/threading/thread_restrictions.h"
13 13
14 #if defined(OS_LINUX) && defined(USE_UDEV) 14 #if defined(OS_LINUX) && defined(USE_UDEV)
15 #include "device/hid/hid_service_linux.h" 15 #include "device/hid/hid_service_linux.h"
16 #elif defined(OS_MACOSX) 16 #elif defined(OS_MACOSX)
17 #include "device/hid/hid_service_mac.h" 17 #include "device/hid/hid_service_mac.h"
18 #else 18 #else
19 #include "device/hid/hid_service_win.h" 19 #include "device/hid/hid_service_win.h"
20 #endif 20 #endif
21 21
22 namespace device { 22 namespace device {
23 23
24 namespace { 24 namespace {
25 25
26 HidService* g_service = NULL; 26 HidService* g_service = NULL;
27 27
28 class HidServiceDestroyer : public base::MessageLoop::DestructionObserver { 28 } // namespace
29
30 class HidService::Destroyer : public base::MessageLoop::DestructionObserver {
29 public: 31 public:
30 explicit HidServiceDestroyer(HidService* hid_service) 32 explicit Destroyer(HidService* hid_service)
31 : hid_service_(hid_service) {} 33 : hid_service_(hid_service) {}
32 virtual ~HidServiceDestroyer() {} 34 virtual ~Destroyer() {}
33 35
34 private: 36 private:
35 // base::MessageLoop::DestructionObserver implementation. 37 // base::MessageLoop::DestructionObserver implementation.
36 virtual void WillDestroyCurrentMessageLoop() OVERRIDE { 38 virtual void WillDestroyCurrentMessageLoop() OVERRIDE {
37 base::MessageLoop::current()->RemoveDestructionObserver(this); 39 base::MessageLoop::current()->RemoveDestructionObserver(this);
38 delete hid_service_; 40 delete hid_service_;
39 delete this; 41 delete this;
40 g_service = NULL; 42 g_service = NULL;
41 } 43 }
42 44
43 HidService* hid_service_; 45 HidService* hid_service_;
44 }; 46 };
45 47
46 } // namespace
47
48 HidService* HidService::GetInstance( 48 HidService* HidService::GetInstance(
49 scoped_refptr<base::SingleThreadTaskRunner> ui_task_runner) { 49 scoped_refptr<base::SingleThreadTaskRunner> ui_task_runner) {
50 if (g_service == NULL) { 50 if (g_service == NULL) {
51 #if defined(OS_LINUX) && defined(USE_UDEV) 51 #if defined(OS_LINUX) && defined(USE_UDEV)
52 g_service = new HidServiceLinux(ui_task_runner); 52 g_service = new HidServiceLinux(ui_task_runner);
53 #elif defined(OS_MACOSX) 53 #elif defined(OS_MACOSX)
54 g_service = new HidServiceMac(); 54 g_service = new HidServiceMac();
55 #elif defined(OS_WIN) 55 #elif defined(OS_WIN)
56 g_service = new HidServiceWin(); 56 g_service = new HidServiceWin();
57 #endif 57 #endif
58 if (g_service != NULL) { 58 if (g_service != NULL) {
59 HidServiceDestroyer* destroyer = new HidServiceDestroyer(g_service); 59 Destroyer* destroyer = new Destroyer(g_service);
60 base::MessageLoop::current()->AddDestructionObserver(destroyer); 60 base::MessageLoop::current()->AddDestructionObserver(destroyer);
61 } 61 }
62 } 62 }
63 return g_service; 63 return g_service;
64 } 64 }
65 65
66 HidService::~HidService() { 66 HidService::~HidService() {
67 DCHECK(thread_checker_.CalledOnValidThread()); 67 DCHECK(thread_checker_.CalledOnValidThread());
68 } 68 }
69 69
(...skipping 34 matching lines...) Expand 10 before | Expand all | Expand 10 after
104 DeviceMap::iterator it = devices_.find(device_id); 104 DeviceMap::iterator it = devices_.find(device_id);
105 if (it != devices_.end()) 105 if (it != devices_.end())
106 devices_.erase(it); 106 devices_.erase(it);
107 } 107 }
108 108
109 const HidService::DeviceMap& HidService::GetDevicesNoEnumerate() const { 109 const HidService::DeviceMap& HidService::GetDevicesNoEnumerate() const {
110 return devices_; 110 return devices_;
111 } 111 }
112 112
113 } // namespace device 113 } // namespace device
OLDNEW
« device/hid/hid_service.h ('K') | « device/hid/hid_service.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698