Issue 542103002: MIPS: remove remnants of MinorKey.

Issue 542103002: MIPS: remove remnants of MinorKey. (Closed)

Created:
6 years, 3 months ago by Yang

Modified:
6 years, 3 months ago

Reviewers:
balazs.kilvady

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Project:
v8

Visibility:
Public.

More Reviews

Description

MIPS: remove remnants of MinorKey. R=balazs.kilvady@imgtec.com

Patch Set 1 #

Created: 6 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -4 lines)			Patch
	M	src/mips/code-stubs-mips.h	View		2 chunks	+0 lines, -2 lines	0 comments	Download
	M	src/mips64/code-stubs-mips64.h	View		2 chunks	+0 lines, -2 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

balazs.kilvady

On 2014/09/05 09:14:27, Yang wrote: Thank you for this fix. But I have just finished ...

6 years, 3 months ago (2014-09-05 09:18:31 UTC) #2

balazs.kilvady

On 2014/09/05 09:18:31, balazs.kilvady wrote: > On 2014/09/05 09:14:27, Yang wrote: > > Thank you ...

6 years, 3 months ago (2014-09-05 09:19:56 UTC) #3

Yang

On 2014/09/05 09:19:56, balazs.kilvady wrote: > On 2014/09/05 09:18:31, balazs.kilvady wrote: > > On 2014/09/05 ...

6 years, 3 months ago (2014-09-05 09:21:04 UTC) #4

balazs.kilvady

6 years, 3 months ago (2014-09-05 09:43:10 UTC) #5

On 2014/09/05 09:21:04, Yang wrote:
> On 2014/09/05 09:19:56, balazs.kilvady wrote:
> > On 2014/09/05 09:18:31, balazs.kilvady wrote:
> > > On 2014/09/05 09:14:27, Yang wrote:
> > > 
> > > Thank you for this fix. But I have just finished the port of r23716
> "Introduce
> > > code stub constructors for stub keys." and I added those fixes also.
> Quickchek
> > > tests are running at the moment.
> > 
> > So is it OK to land only that port?
> 
> sure that would be fine too.

I landed r23721 "MIPS: Introduce code stub constructors for stub keys. Port
r23716 (9118048)" which contains minor key removal also.

Expand Messages | Collapse Messages