Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(99)

Issue 54203005: Remove .clang-format file for now. (Closed)

Created:
7 years, 1 month ago by Nico
Modified:
7 years, 1 month ago
CC:
blink-reviews, Jeffrey Yasskin, eseidel, dglazkov, djasper_google.com
Visibility:
Public.

Description

Remove .clang-format file for now. Not all toplevel OWNERS are convinced with this being useful enough yet. I think we should keep a high bar for new toplevel files. I'm certain .clang-format will pass that bar eventually, but we should wait with adding it until all toplevel OWNERS agree with this assessment. (See comments on https://codereview.chromium.org/23503027/ for background.) BUG=none NOTRY=true Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=161106

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -3 lines) Patch
D .clang-format View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Nico
7 years, 1 month ago (2013-10-31 21:00:11 UTC) #1
Jeffrey Yasskin
lgtm. Too bad though.
7 years, 1 month ago (2013-10-31 21:03:10 UTC) #2
abarth-chromium
LGTM. Sorry for being a stickler
7 years, 1 month ago (2013-10-31 21:26:50 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thakis@chromium.org/54203005/1
7 years, 1 month ago (2013-10-31 21:34:14 UTC) #4
commit-bot: I haz the power
Retried try job too often on linux_blink for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_blink&number=1575
7 years, 1 month ago (2013-10-31 23:51:06 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thakis@chromium.org/54203005/1
7 years, 1 month ago (2013-10-31 23:53:01 UTC) #6
commit-bot: I haz the power
7 years, 1 month ago (2013-10-31 23:54:10 UTC) #7
Message was sent while issue was closed.
Change committed as 161106

Powered by Google App Engine
This is Rietveld 408576698